Skip to content
This repository has been archived by the owner on Jul 29, 2023. It is now read-only.

windows: include process.h in win_pthread.h #86

Merged
merged 1 commit into from
Mar 11, 2022
Merged

windows: include process.h in win_pthread.h #86

merged 1 commit into from
Mar 11, 2022

Conversation

miurahr
Copy link
Owner

@miurahr miurahr commented Mar 10, 2022 •
edited
Loading

  • remove local declaration of _beginthreadex
  • add __stdcall for pthread_create_wrapper

@miurahr miurahr force-pushed the topic-winpthread-beginthreadex branch from 7badc4b to 4f2ef04 Compare March 10, 2022 14:29
@cielavenir
Copy link
Contributor

@miurahr thank you

(x86 32bit could have security matter and I told this via DM)

@miurahr
Copy link
Owner Author

miurahr commented Mar 10, 2022

Windows fatal exception: access violation is happened on 32bit python on Windows.

@miurahr miurahr marked this pull request as draft March 10, 2022 22:24
@miurahr miurahr force-pushed the topic-winpthread-beginthreadex branch from 4f2ef04 to 0e095dc Compare March 10, 2022 22:56
@miurahr miurahr mentioned this pull request Mar 11, 2022
Closed
@miurahr
win_pthread: include process.h
7c33fcf 
- remove local declaration of _beginthreadex
- add __stdcall for pthread_create_wrapper

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
@miurahr miurahr force-pushed the topic-winpthread-beginthreadex branch from 0e095dc to 7c33fcf Compare March 11, 2022 10:27
@miurahr
Copy link
Owner Author

miurahr commented Mar 11, 2022

Rebased on main

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1968254666

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 1967264958: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1968254666

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 1967264958: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@miurahr miurahr marked this pull request as ready for review March 11, 2022 11:06
@miurahr miurahr changed the title Topic winpthread beginthreadex windows: include process.h in win_pthread.h Mar 11, 2022
@miurahr miurahr merged commit 57aab21 into main Mar 11, 2022
@miurahr miurahr deleted the topic-winpthread-beginthreadex branch March 26, 2022 05:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miurahr @cielavenir @coveralls