Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WLGN - Not a smooth process #2

Closed
influxweb opened this issue Jul 11, 2019 · 0 comments

Comments

@influxweb
Copy link
Contributor

commented Jul 11, 2019

When adding a product to your wish list from either the product page or your basket, and you are not logged into your account, the logic of WLGN page is not optimal.

Expected Behavior

When creating an account, you should be returned back to your point of origin so you can add the product(s) to your wish list.

Correcting the Issue

To improve the experience, the code for WLGN needs to be update. I have added this update and it will be included in the next maintenance release.

To make the update prior to the next release, you will need to update the code on WLGN:

User Interface -> Pages -> WLGN -> Template:

<mvt:item name="html_profile" />
<head>
	<meta charset="utf-8">
	<meta http-equiv="X-UA-Compatible" content="IE=edge">
	<meta name="viewport" content="width=device-width, initial-scale=1">
	<base href="&mvt:global:basehref;">
	<mvt:if expr="NOT ISNULL l.settings:page:title">
		<title>&mvt:page:title;</title>
	<mvt:else>
		<title>&mvt:store:name;: &mvt:page:name;</title>
	</mvt:if>
	<mvt:item name="head" param="css_list" />
	<mvt:item name="head" param="head_tag" />
</head>
<body id="js-&mvte:page:code;" class="o-site-wrapper t-page-&mvt:global:pageClass;">
	<mvt:item name="hdft" param="global_header" />

	<section class="o-layout">
		<div class="o-layout__item">
			<mvt:item name="hdft" param="header" />
		</div>
	</section>

	<section class="o-layout">
		<div class="o-layout__item u-width-12">
			<section class="t-expanded-block t-account-landing-section u-bg-white">
				<div class="o-layout__item t-expanded-block__item t-account-landing-section__header u-width-12">
					<mvt:item name="readytheme" param="contentsection( 'messages' )" />
					<div class="o-layout o-layout--wide o-layout--justify-around u-text-center">
						<div class="o-layout__item u-width-12 u-width-6--l u-width-5--w t-customer-profile">
							<div class="t-account-landing-section__header">
								<span class="c-heading-delta t-account-landing-section__heading">Current Customer?</span>
								<p class="u-font-small">Please sign in to view your wish lists.</p>
							</div>
							<form class="u-inline-block u-text-left" method="post" action="&mvte:urls:WISH:secure;" autocomplete="off">
								<fieldset>
									<legend>&mvt:page:name;</legend>
									<mvt:if expr="ISNULL g.Action">
										<mvt:assign name="g.Action" value="'LOGN,ATWL'" />
									<mvt:else>
										<mvt:assign name="g.Action" value="'LOGN,' $ g.Action" />
									</mvt:if>
									<input type="hidden" name="Action" value="&mvte:global:Action;" />
									<input type="hidden" name="Quantity" value="&mvte:global:Quantity;" />
									<input type="hidden" name="Line_ID" value="&mvte:global:Line_ID;" />
									<input type="hidden" name="Group_ID" value="&mvte:global:Group_ID;" />
									<input type="hidden" name="Wish_ID" value="&mvte:global:Wish_ID;" />
									<input type="hidden" name="Product_Code" value="&mvte:global:Product_Code;" />
									<mvt:assign name="l.settings:attribute_index" value="0" />
									<mvt:foreach iterator="attribute" array="global:Product_Attributes">
										<mvt:assign name="l.settings:attribute_index" value="l.settings:attribute_index + 1" />
										<input type="hidden" name="Product_Attributes[ &mvt:attribute_index; ]:code" value="&mvte:attribute:code;" />
										<input type="hidden" name="Product_Attributes[ &mvt:attribute_index; ]:value" value="&mvte:attribute:value;" />
										<mvt:if expr="l.settings:attribute:template_code NE 0">
											<input type="hidden" name="Product_Attributes[ &mvt:attribute_index; ]:template_code" value="&mvte:attribute:template_code;" />
										</mvt:if>
									</mvt:foreach>
									<ul class="c-form-list">
										<li class="c-form-list__item">
											<label class="c-form-label u-font-small u-text-bold u-text-uppercase is-required &mvt:global:invalid_credentials;" for="l-Customer_LoginEmail">Email Address</label>
											<input id="l-Customer_LoginEmail" class="c-form-input" type="email" name="Customer_LoginEmail" value="&mvte:global:Customer_LoginEmail;" autocomplete="email" required>
										</li>
										<li class="c-form-list__item">
											<label class="c-form-label u-font-small u-text-bold u-text-uppercase is-required &mvt:global:invalid_credentials;" for="l-Customer_Password">Password:</label>
											<mvt:if expr="g.Customer_Temporary_Password">
												<input type="hidden" name="Customer_Temporary_Password" value="&mvte:global:Customer_Temporary_Password;">
												<input id="l-Customer_Password" class="c-form-input" type="password" name="Customer_Password" value="&mvte:global:Customer_Temporary_Password;" required>
											<mvt:else>
												<input id="l-Customer_Password" class="c-form-input" type="password" name="Customer_Password" autocomplete="current-password" required>
											</mvt:if>
										</li>
										<li class="c-form-list__item u-text-right">
											<mvt:item name="buttons" param="Login" />
										</li>
									</ul>
								</fieldset>
							</form>
							<p class="u-font-small"><a data-mini-modal data-mini-modal-type="inline" data-mini-modal-content="data-forgot-password" href="&mvte:urls:FPWD:secure;" title="Forgot Password">Forgot your password?</a></p>
							<br>
						</div>
						<div class="o-layout__item u-width-12 u-width-6--l u-width-5--w">
							<div class="t-account-landing-section__header">
								<span class="c-heading-delta t-account-landing-section__heading">No Account? No Problem&hellip;</span>
								<p class="u-font-small">Create an account and add products to your wish list.</p>
							</div>
							<form class="u-inline-block u-text-left" method="post" action="&mvte:urls:CACT:secure;" autocomplete="off">
								<fieldset>
									<legend>Create Account</legend>
									<mvt:if expr="'MAWL' CIN g.Action OR 'MPWL' CIN g.Action">
										<input type="hidden" name="current_location" value="&mvte:urls:BASK:secure_sep;">
									<mvt:else>
										<input type="hidden" name="current_location" value="&mvte:urls:PROD:secure_sep;Product_Code=&mvte:global:Product_Code;&">
									</mvt:if>
									<ul class="c-form-list">
										<li class="c-form-list__item">
											<label class="c-form-label u-font-tiny u-text-bold u-text-uppercase is-required" for="l-register_fname">First Name</label>
											<input id="l-register_fname" class="c-form-input c-form-input--large" type="text" name="register_fname" value="" autocomplete="name given-name" required>
										</li>
										<li class="c-form-list__item">
											<label class="c-form-label u-font-tiny u-text-bold u-text-uppercase is-required" for="l-register_lname">Last Name</label>
											<input id="l-register_lname" class="c-form-input c-form-input--large" type="text" name="register_lname" autocomplete="name family-name" required>
										</li>
										<li class="c-form-list__item">
											<label class="c-form-label u-font-tiny u-text-bold u-text-uppercase is-required" for="l-register_email">Email Address</label>
											<input id="l-register_email" class="c-form-input c-form-input--large" type="email" name="register_email" value="&mvte:global:register_email;" autocomplete="email" required>
										</li>
										<li class="c-form-list__item">
											<label class="c-form-label u-font-tiny u-text-bold u-text-uppercase is-required" for="l-register_password">Password</label>
											<input id="l-register_password" class="c-form-input c-form-input--large" type="password" name="register_password" autocomplete="new-password" required>
										</li>
										<li class="c-form-list__item u-text-right">
											<input class="c-button c-button--full c-button--hollow c-button--huge u-bg-white u-color-gray-50 u-font-small u-text-bold u-text-uppercase" type="submit" value="Create My Account">
										</li>
									</ul>
								</fieldset>
							</form>
							<br>
						</div>
					</div>
			</section>
		</div>
	</section>
	
	<section class="o-layout">
		<div class="o-layout__item">
			<mvt:item name="hdft" param="footer" />
			<mvt:item name="readytheme" param="contentsection( 'forgot-password' )" />
		</div>
	</section>

	<mvt:item name="hdft" param="global_footer" />
</body>
</html>

@influxweb influxweb added this to the v1.0.1 milestone Jul 11, 2019

@influxweb influxweb self-assigned this Jul 11, 2019

influxweb added a commit that referenced this issue Jul 24, 2019

v1.0.1
This maintenance release addresses all issues contained in the v1.0.1 milestone. https://github.com/mivaecommerce/readytheme-colossus/milestone/1?closed=1

This closes #1, closes #2, closes #3, closes #4, closes #5, closes #6, and closes #7
@influxweb influxweb referenced this issue Jul 24, 2019

@influxweb influxweb closed this in #8 Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.