Skip to content

Michael West miwest929

miwest929 commented on pull request mdsol/crichton#223
Michael West

@fosdev Is this something that is actionable in this PR? Can we move forward with this PR?

miwest929 deleted branch service_resources_catalog_fix at mdsol/crichton
Michael West
miwest929 merged pull request mdsol/crichton#222
Michael West
service_resources_catalog fix typo
1 commit with 2 additions and 2 deletions
miwest929 commented on pull request mdsol/crichton#222
Michael West

@fosdev Looks good to me. Mind if I merge?

miwest929 commented on pull request mdsol/crichton#216
Michael West

Curious, why is tap used here?

miwest929 commented on pull request mdsol/crichton#216
Michael West

Since Hash#merge returns a new Hash not sure this will work as expected inside the tap since what's being mutated is not the same object passed into

miwest929 commented on pull request mdsol/crichton-representors#22
Michael West

Curious, why is hash being initialized to nil instead of {}?

Michael West
miwest929 commented on pull request mdsol/kender#49
Michael West

Made the change.

Michael West
  • Michael West 4a02c76
    Move the latest changelog entry to the top
miwest929 commented on pull request miwest929/gatling_rb#1
Michael West

I do. Nothing pains me more than seeing commented out code. It will haunt for days to come unless removed :)

miwest929 commented on pull request miwest929/gatling_rb#1
Michael West

Fair enough. Then I would suggest adding a TODO to remind your future self.

miwest929 commented on pull request miwest929/gatling_rb#1
Michael West

What if it's not set. Should raise an appropriate error in that case.

miwest929 commented on pull request miwest929/gatling_rb#1
Michael West

parenthesis please

miwest929 commented on pull request miwest929/gatling_rb#1
Michael West

Seems superfluous to declare the default value for data to be nil considering by default hash[data] will be nil if not specified.

miwest929 commented on pull request miwest929/gatling_rb#1
Michael West

Suggestion: Add parenthesis....so def initialize(options = {})

Something went wrong with that request. Please try again.