Skip to content

Shared SSO #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Aug 2, 2024
Merged

Shared SSO #1220

merged 33 commits into from
Aug 2, 2024

Conversation

pjboudrx
Copy link
Contributor

@pjboudrx pjboudrx commented Jul 8, 2024

No description provided.

@pjboudrx pjboudrx requested a review from a team as a code owner July 8, 2024 22:02
@pjboudrx pjboudrx requested review from mavlee and removed request for a team July 8, 2024 22:02
Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 7:23pm

Copy link
Collaborator

@kurbycchua kurbycchua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

Copy link
Collaborator

@kurbycchua kurbycchua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

Copy link
Contributor

@themacguffinman themacguffinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not a final review but this is good enough to ship on short notice if we need to

Copy link
Collaborator

@kurbycchua kurbycchua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, just one minor comment on maybe adding one more screen under the Setting Up Shared SSO Step 1, under last statement: "The new Admin Organization will be listed in the left nav in Organization Settings." just for more clarity. I'll leave that for you to decide, not a show stopper.

@pjboudrx pjboudrx enabled auto-merge (squash) August 2, 2024 19:20
@pjboudrx pjboudrx merged commit d4fcfc2 into main Aug 2, 2024
7 checks passed
@pjboudrx pjboudrx deleted the admin-org-sso branch August 2, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants