In-app notifications for landscape only apps #102

Closed
dber1 opened this Issue Jan 23, 2014 · 2 comments

Projects

None yet

3 participants

@dber1
dber1 commented Jan 23, 2014

MPNotificationViewController only supports portrait orientation.

Also, no checks are performed to validate portrait is actually supported, so it simply crashes.

@tomjtobin

+1.
crashes with
Supported orientations has no common orientation with the application, and shouldAutorotate is returning YES

Our app has both landscape orientations and has autorotate on, to allow the user to hold the device either way, but no portrait orientations.
If the device is in landscape, the the popup should just show in the same aspect ration in the middle of the screen.

@malectro
Contributor

Hi guys, this was fixed in our latest release
https://github.com/mixpanel/mixpanel-iphone/releases/tag/v2.3.3

I'm endlessly sorry we didn't get to it earlier as it was a bad issue to leave about. Going forward, takeover notifications will simply not show up in landscape-only apps, but look out for better support in the future.

@malectro malectro closed this Mar 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment