Calling +deviceInfoProperties on each -track:properties: is expensive and redundant #64

Closed
paulshapiro opened this Issue Jun 29, 2013 · 2 comments

Projects

None yet

3 participants

@paulshapiro

I'd recommend caching it at an instance property from Mixpanel's init. If you need to, you can modify parts of it at track-time.

One thing I'd recommend not calling at track-time is +wifiAvailable. Pretty expensive call. You might want to put it in its own queue and change it to an observation pattern instead.

@klazuka

+1. This deviceInfo dictionary should be computed once and cached thereafter.

@malectro

Looks like we do this now.

@malectro malectro closed this Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment