Add readableNameWithDeviceName: on MPDeviceNamer to do proper naming. #113

wants to merge 1 commit into

3 participants


No description provided.


I'd probably recommend doing this server side - but... it's a start.

@yas375 yas375 commented on the diff Feb 20, 2014
+ else if ([deviceName isEqualToString:@"iPad2,4"]) readableName = @"iPad 2 (WiFi)";
+ else if ([deviceName isEqualToString:@"iPad2,5"]) readableName = @"iPad Mini (WiFi)";
+ else if ([deviceName isEqualToString:@"iPad2,6"]) readableName = @"iPad Mini (GSM)";
+ else if ([deviceName isEqualToString:@"iPad2,7"]) readableName = @"iPad Mini (GSM+CDMA)";
+ else if ([deviceName isEqualToString:@"iPad3,1"]) readableName = @"iPad 3 (WiFi)";
+ else if ([deviceName isEqualToString:@"iPad3,2"]) readableName = @"iPad 3 (GSM+CDMA)";
+ else if ([deviceName isEqualToString:@"iPad3,3"]) readableName = @"iPad 3 (GSM)";
+ else if ([deviceName isEqualToString:@"iPad3,4"]) readableName = @"iPad 4 (WiFi)";
+ else if ([deviceName isEqualToString:@"iPad3,5"]) readableName = @"iPad 4 (GSM)";
+ else if ([deviceName isEqualToString:@"iPad3,6"]) readableName = @"iPad 4 (GSM+CDMA)";
+ else if ([deviceName isEqualToString:@"iPad4,1"]) readableName = @"iPad Air (WiFi)";
+ else if ([deviceName isEqualToString:@"iPad4,2"]) readableName = @"iPad Air (GSM)";
+ else if ([deviceName isEqualToString:@"iPad4,4"]) readableName = @"iPad Mini Retina (WiFi)";
+ else if ([deviceName isEqualToString:@"iPad4,5"]) readableName = @"iPad Mini Retina (GSM)";
+ else if ([deviceName isEqualToString:@"i386"]) readableName = @"Simulator";
+ else if ([deviceName isEqualToString:@"x86_64"]) readableName = @"Simulator";
yas375 Feb 20, 2014

I think the use of dictionary would be more appropriate here.
But better to do such things on the server, imo.


Hi @seivan

We will be doing this translation on the server, so we can update more easily as new devices become available. I don't have an ETA for this at the moment unfortunately.

@seivan seivan deleted the unknown repository branch Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment