Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve push tracking #879

Merged
merged 13 commits into from Feb 11, 2020
Merged

Improve push tracking #879

merged 13 commits into from Feb 11, 2020

Conversation

jbwyme
Copy link
Contributor

@jbwyme jbwyme commented Feb 4, 2020 •
edited

  • Adds trackPushNotificationEventFromRequest to track events using the token and distinct_id we receive from the push payload
  • Adds a $push_notification_received event that is tracked when the device receives the notification
  • Some other minor cleanup

@jbwyme jbwyme changed the title Add additional track props for tap event Improve push tracking Feb 4, 2020
zihejia
zihejia approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@zihejia zihejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbwyme jbwyme merged commit f17b8e7 into master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aecast aecast aecast left review comments

@zihejia zihejia zihejia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbwyme @aecast @zihejia