Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Download portaudio 19.7.0 for compatinility with Ventura 13.0 #11046

Merged
merged 1 commit into from Nov 17, 2022

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Nov 7, 2022

and weak-link to required frameworks.

closes #11019

@daschuer
Copy link
Member Author

daschuer commented Nov 8, 2022

@kFYatek has confirmed that this is working and the bug is fixed. Merge?

@daschuer
Copy link
Member Author

We have another user suffering this issue here:
https://bugs.launchpad.net/mixxx/+bug/1897466/comments/4
Can one have a look and merge it?

@Swiftb0y
Copy link
Member

isn't the proper fix here to update the macOS build environment?

@daschuer
Copy link
Member Author

Yes, of cause. Unfortunately we have no working CI for the of build environment. That's why I took here such a workaround. I considrf the alternative of switching to vcpkg as not appropriate for a stable branch as well as reviving the old CI.
This solution has the lowest regression risk.

@Swiftb0y
Copy link
Member

Since its been 10 days an nobody else bothered to comment, I'll merge.

@Swiftb0y Swiftb0y merged commit dbfad39 into mixxxdj:2.3 Nov 17, 2022
@daschuer daschuer deleted the macos_portaudio branch January 3, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants