Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some WColorPicker fixes #11439

Merged
merged 3 commits into from Apr 5, 2023
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Apr 4, 2023

fixing some bugs I noticed when I actually just wanted to set a checkmark for the selected colors in
Preferences > Colors > Replace Cue color

  • prevent color button being resized when setting an icon (preferences, hotcue menu & track menu)
    Previously, color buttons would shrink when setting the checkmark icon. For me this is fixed now, please test
  • set a checkmark on selected color buttons (for the color pickers in hotcue menu & track menu this is done via res/skins/default.qss)
  • fix initial check state in Preferences > Colors > Replace Cue color

@github-actions github-actions bot added the ui label Apr 4, 2023
@ronso0 ronso0 force-pushed the colorpicker-button-size-fix branch from 8382533 to d736694 Compare April 4, 2023 16:51
@ronso0 ronso0 changed the title WColorPicker: prevent color button being resized when setting an icon some WColorPicker fixes Apr 4, 2023
This allows setting the checkmark on the selected color button when the color picker
can't be styled with external qss. For now only used by DlgReplaceCueColor in the
color preferences page.
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works also good. Thank you.

@daschuer daschuer merged commit c0f31df into mixxxdj:2.3 Apr 5, 2023
8 checks passed
@daschuer daschuer added this to the 2.3.5 milestone Apr 5, 2023
@ronso0 ronso0 deleted the colorpicker-button-size-fix branch April 5, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants