Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skins: update preview images for LateNight 64 sampler skins #12792

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented Feb 11, 2024

fixes: #11763

@ronso0
Copy link
Member

ronso0 commented Feb 11, 2024

Thanks.
Why 4k images? The previews are 640x360 (1280x720 with 200%) and can't be zoomed. I don't thnk we need that extra 1 MB here.

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those need to be in LateNight (64 Samplers) ; )

@ywwg
Copy link
Member Author

ywwg commented Feb 11, 2024

I can shrink them more if you want

@ronso0
Copy link
Member

ronso0 commented Feb 11, 2024

I can shrink them more if you want

Yes, please use 1920x1080, it's just the ratio (16:9) matches that of the preview label
The images of this PR are all 1920:1200, therefore the preferences label won't use the available width

skinPreviewLabel->setPixmap(preview.scaled(
QSize(640, 360) * m_dDevicePixelRatio,
Qt::KeepAspectRatio,
Qt::SmoothTransformation));

@ywwg ywwg requested a review from ronso0 February 11, 2024 20:07
@ywwg
Copy link
Member Author

ywwg commented Feb 11, 2024

ok yeah can do.

@ronso0 ronso0 merged commit 81066fd into mixxxdj:2.4 Feb 11, 2024
14 checks passed
@ronso0
Copy link
Member

ronso0 commented Feb 11, 2024

Yup, looking good now. Thank you!

@ronso0
Copy link
Member

ronso0 commented Feb 11, 2024

oh, we could have squashed into one. Hmm next time..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants