Decrease Reverb Decay #1502
Decrease Reverb Decay #1502
Conversation
| input.bandwidth.set(exp(-M_PI * (1. - (.005 + .994*bandwidthParam)))); | ||
| // set decay | ||
| sample_t decay = .749*decayParam; | ||
| sample_t decay = .890*decayParam; |
There was a problem hiding this comment.
This function has a lot of magic numbers. Does anyone know where they came from? Guessing and checking until it sounded good? @rryan do you know?
There was a problem hiding this comment.
This PR is just changing the max decay paramter until I found a value I liked. Now I find the reverb way more useful: you can generate a long reverb tail and filter it out with the moog filter. Sweet :)
|
I tested this and it sounds good to me. Does the decay parameter correspond to a specific value of time in milliseconds? It would be good to note the range in the parameter's tooltip. |
|
I have no idea
2018-02-03 18:16 GMT+01:00 Be <notifications@github.com>:
… I tested this and it sounds good to me. Does the decay parameter
correspond to a specific value of time in milliseconds? It would be good to
note the range in the parameter's tooltip.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1502 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGIcT4_or4cH4XtGqa3lwmeAeWtUmkknks5tRJRTgaJpZM4Rvdnw>
.
|
|
Okay, it's not terribly important to know that information for this use case. |
|
Thanks!
2018-02-03 23:22 GMT+01:00 Be <notifications@github.com>:
… Merged #1502 <#1502>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1502 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGIcT2ptFfCZ-WSOLics-v8HprigZjfaks5tRNxCgaJpZM4Rvdnw>
.
|
|
Whoops, I noticed this was targeted at the master branch. I rebased it on 2.1 for the release. |
…b-Decay Decrease Reverb Decay
2 participants
I feel the reverb is not powerful enough. This PR addresses the issue.