From ae1f5545ed893537d609ece55daf0c1a631e5b22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= Date: Fri, 4 Jan 2019 16:52:42 +0100 Subject: [PATCH 1/2] fix audiotaperpot_test lp1810495 --- src/test/audiotaperpot_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/audiotaperpot_test.cpp b/src/test/audiotaperpot_test.cpp index 3b3e611a687..ace48736532 100644 --- a/src/test/audiotaperpot_test.cpp +++ b/src/test/audiotaperpot_test.cpp @@ -20,7 +20,7 @@ TEST_F(AudioTaperPotTest, ScaleTest) { // Parameter 0 is always 0 (-Infinity) ASSERT_EQ(1.0, catpb.parameterToValue(neutralParameter)); // Parameter 1 is always maxDB - ASSERT_EQ(db2ratio(maxDB), catpb.parameterToValue(1)); + ASSERT_DOUBLE_EQ(db2ratio(maxDB), catpb.parameterToValue(1)); // value 1 is always on a Integer midi value double neutralMidi = catpb.valueToMidiParameter(1); ASSERT_EQ(0.0, fmod(neutralMidi, 1)); From c860d10eaf38a05cf369e1f5717603da1260f1a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= Date: Sat, 20 Apr 2019 01:30:42 +0200 Subject: [PATCH 2/2] use more ASSERT_DOUBLE_EQ --- src/test/audiotaperpot_test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/audiotaperpot_test.cpp b/src/test/audiotaperpot_test.cpp index ace48736532..ff41cfece28 100644 --- a/src/test/audiotaperpot_test.cpp +++ b/src/test/audiotaperpot_test.cpp @@ -41,7 +41,7 @@ TEST_F(AudioTaperPotTest, ScaleTest) { // Parameter 0 is always 0 (-Infinity) ASSERT_EQ(1.0, catpb.parameterToValue(neutralParameter)); // Parameter 1 is always maxDB - ASSERT_EQ(db2ratio(maxDB), catpb.parameterToValue(1)); + ASSERT_DOUBLE_EQ(db2ratio(maxDB), catpb.parameterToValue(1)); // value 1 is always on a Integer midi value double neutralMidi = catpb.valueToMidiParameter(1); ASSERT_EQ(0.0, fmod(neutralMidi, 1)); @@ -62,7 +62,7 @@ TEST_F(AudioTaperPotTest, ScaleTest) { // Parameter 0 is always 0 (-Infinity) ASSERT_EQ(1.0, catpb.parameterToValue(neutralParameter)); // Parameter 1 is always maxDB - ASSERT_EQ(db2ratio(maxDB), catpb.parameterToValue(1)); + ASSERT_DOUBLE_EQ(db2ratio(maxDB), catpb.parameterToValue(1)); // value 1 is always on a Integer midi value double neutralMidi = catpb.valueToMidiParameter(1); ASSERT_EQ(0.0, fmod(neutralMidi, 1));