Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infobar #3406

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Infobar #3406

wants to merge 6 commits into from

Conversation

poelzi
Copy link
Contributor

@poelzi poelzi commented Dec 6, 2020

This PR adds a Infobar into the library to show additional information about track selection and later notifications that are not
well presented on the table view. This is the successor of #1656

Screenshot_20201206_011916

The infobar has currently 3 widgets:

  • crates
  • playlists
  • history

Each widgets shows buttons for each entry. The widget itself has 3 visibility states:

  • collapsed (only the button of the category in a grey symbol)
  • visible (the widget has some medium size but grows if necessary)
  • extended (widget takes as much space as possible)

todo

  • safe state
  • context menu
  • add to other skins
  • finish styling

For later PRs:

  • Add configuration panel to allow full configuration of the status bar
    • maybe DND of elements
  • which widgets
  • order of widgets
  • Add more exotic but useful widgets
    • free space
  • crate/playlist colors
  • when notification infrastructure lands, show the last message for n seconds

@Be-ing
Copy link
Contributor

Be-ing commented Dec 6, 2020

If you move analysis progress here we could finally get rid of the clumsy Analysis library feature.

@Holzhaus
Copy link
Member

Holzhaus commented Dec 6, 2020

Thank, could be useful for displaying crates/playlists and maybe custom tags.

I disagree this that this should be used for notifications though.

The main reason why I think notifications are needed is to get rid of the popup dialogs that block the view. For a ample, if a controller mapping has a bug in an input handler. Or when we finally have hotplug support, we'd probably have a dialog "You connected device X, do you want to set it up". This is annoying, which is why I think a notification area is the way to go. A status bar isn't suitable for this use case IMHO.

@poelzi
Copy link
Contributor Author

poelzi commented Dec 6, 2020

It already shows crates and playlists.
@Holzhaus don't get me wrong, what you are building is exactly right. The status bar is not for managing notification etc.
But when a new notification happens, for 2-3 seconds the message is displayed there and then it switches back to the normal display. The same goes when I navigate a menu, the statusbar should display the help description of the entry.
I don't like to have popups when new notifications happen, I like a icon that displays if something is running and how many unread notifications I have. It should open on shortcut or press, but to no time I want to see something popping up with no user interaction. It might be that it laps over something that is important right now, like a waveform while doing a transit.
Using the statusbar for some seconds to display to new message is the right place for me and should be at least an option later.

@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Mar 7, 2021
Add infobar which shows crate/playlist/history information about
track selection
Use a QStatusBar as basis.
Properly encapsulate each category into one custom widget
Add 3 states for the Widget, closed, normal, expanded
query crates, playlists and history
Update crates when track assignment change.
@Russe
Copy link
Contributor

Russe commented Mar 3, 2022

I wonder weather it's possible to display information at status bar like a file manager? Here are some examples:

  • number of tracks in current library view
  • number of selected tracks in current library view

@github-actions github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Mar 4, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build library skins stale Stale issues that haven't been updated for a long time. ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants