CachingReader: Fix assertion when loop is before track start (lp1946759) #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
suggested changes
Oct 12, 2021
When setting a loop in front of the actual track (i.e. so that the end
of the loop is before the first audio frame), a debug assertion is
always triggered:
DEBUG ASSERT: "hintFrameCount >= 0" in function void CachingReader::hintAndMaybeWake(const HintVector&) at /home/jan/Projects/mixxx/src/engine/cachingreader/cachingreader.cpp:535
Steps to reproduce:
1. Go to the beginning of the track
2. Use beatjump to go to 8 beats before the beginning of the track
3. Set a beatloop of 4 beats
4. Assertion is triggered
See https://bugs.launchpad.net/mixxx/+bug/1946759 for details.
Holzhaus
force-pushed
the
cachingreader-assert-fix
branch
from
46b1b1b
to
74a5173
Compare
Holzhaus
changed the title
uklotzde
approved these changes
Oct 12, 2021
|
Thank you! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting a loop in front of the actual track (i.e. so that the end
of the loop is before the first audio frame), this debug assertion is
always triggered:
Steps to reproduce:
This fixes the issue by just ignoring the negative hint lengthswithout triggering an assertion.
This also re-adds the skipping of zero-length hints that was removed by7d96c38 (#3081) to avoid triggering the
assertion. However, I think skipping was correct in the zero length
case, just triggering the assertion was not.
See https://bugs.launchpad.net/mixxx/+bug/1946759 for details.
The commit that originally introduced this assertion is8589930 (#1223).