Deere: Refactored mixer buttons. #682
Conversation
…d pause icon along the way.
…e them just as the other regular buttons. Fixes https://bugs.launchpad.net/mixxx/+bug/1094928
Conflicts: res/skins/Deere/deck_overview_row.xml
…toggling the key had no effect/would not update state on change
* Add menu svg icon for skin settings toggle. * Add variable for custom <Tooltip> to 2state_button template, because a skin setting is unique to Deere (no <existing <TooltipId> available>). Tooltip won't be i18n able though. Move to tooltips.cpp?
…t. Now follows the left->down, right->up convention.
… of text in the loop section.
…he icons instead of unicode characters in the loop section.
…ling cue/master mix After talking to daschuer on lp:1458213, I realize that headphone gain should not regularly be manipulated while DJing. So, remove that from the mapping and make the knobs control filters by default. With shift, the right knob still controls cue/master mix and turning it all the way to the right toggles split cue mode.
makes a convenient way to quickly seek across large sections of tracks
Before, volume faders could not be moved very quickly
be a little more explicit
I think this text size is what we want at the end. The good solution for me is to fix Bug #1395245. However this means new code and someone will have to review it. :) The alternative is to revert the fx knobs text size back to the small size. It's ugly, but it's a fast hack. Which approach shall I take? |
|
no, it is too late to come up with a design for adding short text to all the effects. I think if we make the effect knobs a little smaller and make the box just a few pixels taller we can go back to the old font size and make sure the text is not touching the knobs |
|
Ok, here you have a first approach. I've also changed the position of the super and d/w knobs. Before, they were on the first fx row, taking a lot of space from it. Now they are vertical and in a column next to the three fx rows, so the effects are now the same size. |
|
still seeing this: |
|
What about this?
|
|
much better |
|
heh, try shrinking the skin down to minimal width -- bad things start happening. Change the minimum size to 1024, 700 and I think we're ok |
|
btw here is the selection color issue I mentioned. This probably happens because the skin is not defining specific values for selection colors and the colors are being picked up from the default theme, which may be different on different computers. Check out how latenight themes the library for guidance. |
|
Because how I put the knobs of the minimized effects units, it needs to be 1170x700. This can be really optimized but involves a lot of work and re-thinking, lets leave it like this for 1.12. |
|
Is there any way to get down to 1024? We've had a lot of complaints about latenight taking up too much space on small screens so if we can save those 50 pixels somehow it would be a big win. |
|
Ok, it was not that hard :) Now let me check this issue with the library colours. By the way, my priority right now is to push 1.12, but unless you keep pointing me to more skin issues, I'll put my time to other parts of Mixxx. Is there other 1.12 blockers nobody is taking care of? |
|
I have no idea about what's happening with your colours. I see on the image that the selection colour is a gradient, but there's no gradient specified on the QTableView section of style.qss. Maybe you have the skin files somehow messed up? Or maybe your desktop environment is overriding the colours. Is that possible? |
|
First, that selection color is the unfocused selection color. As I described, I believe that gradient is part of my system's theme. And since the skin doesn't define that color, the system theme version shows through. Like I said, look at latenight, I even figured out how to style the scrollbar correctly! ferranpujolcamins#1 |
Deere: Fix styling for selected Treeview items
|
I've just made the scroll bars blue :) |
|
cool, if you can just fix the conflicts that github is reporting I'll merge it in |
Conflicts: res/skins/Deere/skin.xml
|
Done! |
…uttons Deere: Refactored mixer buttons.
|
didn't realize this was targetted to master. manually merged to 1.12 |
|
Ooops, my fault. Thank you. 2015-08-29 2:26 GMT+02:00 Owen Williams notifications@github.com:
|
9 participants
New mixer layout with better usable buttons!