Late night coverart splitter #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the cover art collepsible.
|
Please include a screenshot with PRs that change the GUI. |
|
|
|
This is ready to merge. |
|
Thanks for doing this. One more check before I merge, can you show me what mixxx looks like on first-start with this change? Like, move your ~/.mixxx folder to ~/.mixxx-divert and let mixxx start up without any settings whatsoever. I just want to make sure that the default sizes and settings are still good |
|
(that has been a big problem in the past) |
|
This is what Mixxx looks like on a first start with the skin at its minimum size. And this is maximized (screen resolution 1920x1080). |
|
looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Adds a splitter between coverart and library sidebar in LateNight.
https://bugs.launchpad.net/mixxx/+bug/1517649
*Adds a new tag to to specify which children can be collapsed.
*Make coverart non collapsible in all skins, since we have the CO to show/hide it.