New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing files to follow Spotter's Guide #2

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ItaloGoncales

ItaloGoncales commented Oct 28, 2015

Hi Miyagawa,

The main goal with this PR was to add missing documentation like MANIFEST and LICENSE, to follow the SpotterGuide.

I also tweaked the formatting of the Changes file, to match the most widely used format.

Cheers,
Italo Goncales

@miyagawa

This comment has been minimized.

Owner

miyagawa commented Oct 28, 2015

MANIFEST and LICENSE will be automatically generated by the tool, and Changes file format is basically a personal taste.

Thanks for the patch, but I'm not interested in merging changes that are for the sake of changes. Sorry.

If you like, I can convert the dist to Minilla which will make sure that the LICENSE file be added back to the repo.

miyagawa added a commit that referenced this pull request Oct 28, 2015

@miyagawa

This comment has been minimized.

Owner

miyagawa commented Oct 28, 2015

It is already using milla, and i just re-ran it to build LICENSE file in the repo (previous version didn't do it by default).

@miyagawa miyagawa closed this Oct 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment