Using unix socket Starman doesn't set SERVER_NAME or SERVER_PORT #24

Closed
ptf opened this Issue Mar 31, 2011 · 5 comments

Comments

Projects
None yet
6 participants
@ptf

ptf commented Mar 31, 2011

When using Plack::Middleware::Lint and Starman running with a Unix socket. Lint croaks due to the PSGI environment not having SERVER_NAME or SERVER_PORT values

@bugthing

This comment has been minimized.

Show comment
Hide comment
@bugthing

bugthing May 31, 2011

I also have this issue

I also have this issue

@hstaugaard

This comment has been minimized.

Show comment
Hide comment
@hstaugaard

hstaugaard Nov 7, 2011

Also struggling with this. Maybe something like $env->{SERVER_NAME} //= $env->{HTTP_HOST} could be added to the code?

Also struggling with this. Maybe something like $env->{SERVER_NAME} //= $env->{HTTP_HOST} could be added to the code?

@ironcamel

This comment has been minimized.

Show comment
Hide comment
@ironcamel

ironcamel Nov 14, 2011

I am having this issue as well.

I am having this issue as well.

@zallison

This comment has been minimized.

Show comment
Hide comment
@zallison

zallison Apr 18, 2012

This is still a problem

This is still a problem

@miyagawa

This comment has been minimized.

Show comment
Hide comment
@miyagawa

miyagawa Jun 25, 2012

Owner

Alright, sorry for not being responsive on this ticket. The workaround for this is to use starman command instead of plackup -s Starman or to disable development mode with -E deployment. It's a Lint middleware complaining the lack of the said param, which is a non-issue on production.

But anyway it needs to be fixed - hasn't anyone come up with a patch after all these "I also have this"?

Owner

miyagawa commented Jun 25, 2012

Alright, sorry for not being responsive on this ticket. The workaround for this is to use starman command instead of plackup -s Starman or to disable development mode with -E deployment. It's a Lint middleware complaining the lack of the said param, which is a non-issue on production.

But anyway it needs to be fixed - hasn't anyone come up with a patch after all these "I also have this"?

@miyagawa miyagawa closed this in b8df07a Jun 25, 2012

miyagawa added a commit that referenced this issue Jun 25, 2012

Checking in changes prior to tagging of version 0.3001.
Changelog diff is:

diff --git a/Changes b/Changes
index d14f67e..09c5eb9 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 Revision history for Perl extension Starman

+0.3001  Mon Jun 25 10:57:20 PDT 2012
+        - Fix SERVER_NAME and SERVER_PORT not exist on UNIX socket mode #24
+        - Improved documentation
+        - Ensure that chunk buffer contains terminating HTTP newline (Peter Makholm)
+
 0.3000  Mon Feb 20 16:31:44 PST 2012
         - This be a 0.3 release

miyagawa added a commit that referenced this issue Sep 25, 2012

Checking in changes prior to tagging of version 0.3002.
Changelog diff is:

diff --git a/Changes b/Changes
index 09c5eb9..ddd8029 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 Revision history for Perl extension Starman

+0.3002  Tue Sep 25 15:26:43 JST 2012
+        - Added a documentation for --signal-on-term for Server::Starter 0.12 (kazuho, ether)
+        - Set REMOTE_PORT PSGI environment variable #50 (dex4er)
+        - Fix a test failure with a directory containing whitespace (clkao)
+
 0.3001  Mon Jun 25 10:57:20 PDT 2012
         - Fix SERVER_NAME and SERVER_PORT not exist on UNIX socket mode #24
         - Improved documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment