Skip to content

Loading…

Using unix socket Starman doesn't set SERVER_NAME or SERVER_PORT #24

Closed
ptf opened this Issue · 5 comments

6 participants

@ptf

When using Plack::Middleware::Lint and Starman running with a Unix socket. Lint croaks due to the PSGI environment not having SERVER_NAME or SERVER_PORT values

@bugthing

I also have this issue

@hstaugaard

Also struggling with this. Maybe something like $env->{SERVER_NAME} //= $env->{HTTP_HOST} could be added to the code?

@ironcamel

I am having this issue as well.

@zallison

This is still a problem

@miyagawa
Owner

Alright, sorry for not being responsive on this ticket. The workaround for this is to use starman command instead of plackup -s Starman or to disable development mode with -E deployment. It's a Lint middleware complaining the lack of the said param, which is a non-issue on production.

But anyway it needs to be fixed - hasn't anyone come up with a patch after all these "I also have this"?

@miyagawa miyagawa closed this in b8df07a
@miyagawa miyagawa added a commit that referenced this issue
@miyagawa Checking in changes prior to tagging of version 0.3001.
Changelog diff is:

diff --git a/Changes b/Changes
index d14f67e..09c5eb9 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 Revision history for Perl extension Starman

+0.3001  Mon Jun 25 10:57:20 PDT 2012
+        - Fix SERVER_NAME and SERVER_PORT not exist on UNIX socket mode #24
+        - Improved documentation
+        - Ensure that chunk buffer contains terminating HTTP newline (Peter Makholm)
+
 0.3000  Mon Feb 20 16:31:44 PST 2012
         - This be a 0.3 release
1e2415f
@miyagawa miyagawa added a commit that referenced this issue
@miyagawa Checking in changes prior to tagging of version 0.3002.
Changelog diff is:

diff --git a/Changes b/Changes
index 09c5eb9..ddd8029 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 Revision history for Perl extension Starman

+0.3002  Tue Sep 25 15:26:43 JST 2012
+        - Added a documentation for --signal-on-term for Server::Starter 0.12 (kazuho, ether)
+        - Set REMOTE_PORT PSGI environment variable #50 (dex4er)
+        - Fix a test failure with a directory containing whitespace (clkao)
+
 0.3001  Mon Jun 25 10:57:20 PDT 2012
         - Fix SERVER_NAME and SERVER_PORT not exist on UNIX socket mode #24
         - Improved documentation
434e23f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.