Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Keep Alive causing flakey performance #6

Closed
patspam opened this Issue · 1 comment

2 participants

@patspam

I'm getting strange performance behaviour with Starman 0.1006.

Unfortunately my test case is "run this big complex webapp" so I'm not sure how useful this bug report is going to be.

Basically, on the new PSGI branch of WebGUI, I get stable ~300 req/sec when running under Starlet.
Performance is measured via: ab -t 5 -c 10 -k

Whereas when using Starman, I get anything from 1 req/sec to 30 req/sec. No errors or warnings that I can see, just crazy performance.

Tried --workers 1 but nothing changed.

Tried --disable-keepalive and problem immediately went away (getting stable ~370 req/sec).

To double-check that it wasn't a keepalive problem caused by WebGUI, I tried Starlet with --max-keepalive-reqs 100, but the reqs/sec didn't change.

Happy to help debug this, but not sure where to start.

Cheers,

Patrick

@miyagawa
Owner

Disable keep-alive if the request is HTTP/1.0 and there's no Content-Length. Closed by c574964

@clkao clkao referenced this issue from a commit in clkao/Starman
@miyagawa Disable keep-alive if the request is HTTP/1.0 and there's no Content-…
…Length. Fixes gh-6
c574964
@clkao clkao referenced this issue from a commit in clkao/Starman
@miyagawa Checking in changes prior to tagging of version 0.1007.
Changelog diff is:

diff --git a/Changes b/Changes
index 31b97ad..782453d 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,9 @@
 Revision history for Perl extension Starman

+0.1007 Tue Apr 13 19:45:59 PDT 2010
+        - Fixed a bug where Content-Length less response are sent in Keep-Alive without chunked,
+          choking HTTP/1.0 clients (patspam) #6
+
 0.1006 Tue Apr 13 00:01:23 CEST 2010
         - Fixed 100% CPU loop when an unexpected EOF happens (Graham Barr)
8f2c9ee
@clkao clkao referenced this issue from a commit in clkao/Starman
@miyagawa Checking in changes prior to tagging of version 0.2000.
Changelog diff is:

diff --git a/Changes b/Changes
index 782453d..8fe8a44 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 Revision history for Perl extension Starman

+0.2000 Tue Apr 13 20:22:24 PDT 2010
+        - INCOMPATIBLE: starman executable by default loads the application with Delayed to be safer.
+          Use --preload-app command line option to preload the application in the master process.
+          See `starman --help` for details.
+
 0.1007 Tue Apr 13 19:45:59 PDT 2010
         - Fixed a bug where Content-Length less response are sent in Keep-Alive without chunked,
           choking HTTP/1.0 clients (patspam) #6
78ae4b6
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.