Make READ_TIMEOUT configurable on the command line #44

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@yannk
yannk commented Mar 22, 2012

It allows Starman to sit nicely behind a balancer keeping backend connections
open for a long time (pre-opening or just using keep-alive). Without
this change the behaviour is 5 seconds timeout, and depending on backend
utilization it could be likely that a new request hit the timeout just after
a client connection comes in.

t=0.0s, balancer opens connection, Starman block reading headers.
t4.9s, client connection hits balancer, balancer assign preopened
backend.
t
5.0s, timeout!
t~5.0s, RST if race. or FIN to balancer with request not processed.

@yannk yannk Make READ_TIMEOUT configurable on the command line
It allows Starman to sit nicely behind a balancer keeping backend connections
open for a long time (pre-opening or just using keep-alive). Without
this change the behaviour is 5 seconds timeout, and depending on backend
utilization it could be likely that a new request hit the timeout just after
a client connection comes in.

t=0.0s, balancer opens connection, Starman block reading headers.
t~4.9s, client connection hits balancer, balancer assign preopened
        backend.
t~5.0s, timeout!
t~5.0s, RST if race. or FIN to balancer with request not processed.
927adfe
@miyagawa
Owner

I like to merge this patch but it doesn't seem to apply cleanly against the current master. Can you rebase and do push -f ? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment