Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

%extra to $self->{extra} #91

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

It will be pretty good for Starman extension, for example, for enabling log4perl.

  • I can partially override run method with these changes.
Owner

miyagawa commented Oct 22, 2013

Elaborate a bit on the actual usage?

I don't like to expose the internal data structure (hash key) to be overridable though since that's fragile.

There are some useful flags in Net::Server package. For example - log4perl flags (log4perl_conf, log4perl_logger). I completely agree with fragility of overridable internal data structures, but, at now impossible inherit Starman and pass these flags to Net::Server.
As for me, another solution is create method in Starman::Server that will process %extra, like
sub _patch_extra {} or something like that.
Thanks for quick response.

@justnoxx justnoxx closed this Oct 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment