New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict, warnings, some dependencies #24

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mishin

mishin commented Feb 2, 2015

Hi Miyagawa,
according to CPAN-PRC Pull-Request
https://github.com/CPAN-PRC/resources/wiki/My-first-Pull-Request
http://pullrequest.blogspot.ru/

, Neil give me your module, I:

  • add “use warnings;” in all modules
  • Add missing prereqs to Makefile.PL
  • make sure all modules have “use strict”

add use strict;use warnings; add dependencies according to scandeps.pl -R *.pm

good luck

@miyagawa

This comment has been minimized.

Show comment
Hide comment
@miyagawa

miyagawa Feb 2, 2015

Owner

Sorry, but i cannot merge this:

  • use warnings, or even use strict, is not necessary when you use Moose-family modules because it enables them by default. Adding them is anti-DRY.
  • your prereq updates specifies the current latest version for every module, which is not the actual requirements.
Owner

miyagawa commented Feb 2, 2015

Sorry, but i cannot merge this:

  • use warnings, or even use strict, is not necessary when you use Moose-family modules because it enables them by default. Adding them is anti-DRY.
  • your prereq updates specifies the current latest version for every module, which is not the actual requirements.

@miyagawa miyagawa closed this Feb 2, 2015

@mishin

This comment has been minimized.

Show comment
Hide comment
@mishin

mishin Feb 3, 2015

thanks for the detailed comment

mishin commented Feb 3, 2015

thanks for the detailed comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment