New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/disconnect.t fails on 5.10.1 #27

Open
und3f opened this Issue Apr 3, 2012 · 5 comments

Comments

Projects
None yet
5 participants
@und3f
Copy link
Contributor

und3f commented Apr 3, 2012

Test named "got empty response to incomplete header request" from t/disconnect.t fails on perl 5.10.1 http://tinyurl.com/7bm68z2

@perlpunk

This comment has been minimized.

Copy link

perlpunk commented Jul 30, 2012

I also get a failure on 5.10.1
I asked on irc.perl.org#plack
If I output $data before the failing test I get:

t/disconnect.t ................ 
ok 1 - got empty response to empty request
data=<HTTP/1.0 400 Bad Request
Content-Type: text/plain

>
not ok 2 - got empty response to incomplete header request

1..2
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests 

Twiggy 0.1020

@und3f

This comment has been minimized.

Copy link
Contributor

und3f commented Jul 30, 2012

This test is wrong by nature. It simulates close with shutdown on write.

@dolmen

This comment has been minimized.

Copy link

dolmen commented Oct 29, 2013

Is it safe to assume this test is broken and skip it if it fails on 5.10.1?

@pjfl

This comment has been minimized.

Copy link

pjfl commented Mar 27, 2014

If this isn't going to be fixed (and it's now 2 years old) you should raise the minimum required Perl version above 5.10.1 to signal a lack of support. At least that way people won't see it as module that just fails to install

@twata1

This comment has been minimized.

Copy link

twata1 commented Nov 24, 2017

I created a patch and confirmed t/disconnect.t passed on Strawberry Perl 5.10.1(Windows 7 32bit).
However, I think that someone can make a better patch.

Twiggy-0.1025.gh-27.patch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment