High CPU load on terminated post data #25

Merged
merged 1 commit into from Feb 21, 2012

Conversation

Projects
None yet
2 participants
Contributor

und3f commented Feb 20, 2012

In case of termination processing of POST data Twiggy entered infinity loop.

This patch fixes high CPU load in case of terminated transmission during sending POST request data. It was described in #10.

The only sign of problem is high CPU load, so it looks impossible to write test case.

@und3f und3f Fixed broken data processing
In case of termination processing of POST data Twiggy entered infynity
loop.
fba6106
Owner

miyagawa commented Feb 20, 2012

No need to write a CPU high load test, but can write a unit test to give an error in broken data POST?

Contributor

und3f commented Feb 20, 2012

The exception is raised inside of tcp_server callback, I don't see a way to catch it.
Also client can't check server's response because it needs to disconnect to raise the problem.

@miyagawa miyagawa added a commit that referenced this pull request Feb 21, 2012

@miyagawa miyagawa Merge pull request #25 from und3f/master
High CPU load on terminated post data
dc8778c

@miyagawa miyagawa merged commit dc8778c into miyagawa:master Feb 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment