Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

pin source URLs with "at" or "via" #6

Closed
miyagawa opened this Issue · 10 comments

3 participants

@miyagawa
Owner
require 'Plack', '1.0000', at => 'git://github.com/tokuhirom/Plack.git@deadbeef';

it's questionable whether it should support 'dev' option as well for search inclusion, but in most cases you should be able to specify the exact dev version such as:

require 'Plack', '1.0017'; # which is -TRIAL on CPAN
@masaki

I thought, it's better than miyagawa/qahack-tokyo#6
because "at" or "via" do not depend on any VCS (git, svn, ...).
I want to rewrite my patch...

@miyagawa
Owner

yeah that's true. however, there's a problem with the 'at' approach - it's ambiguous.

Sometimes there's a http: URL that "looks like" a git URL but maybe it doesn't. Or, there's a "@" somewhere in the URL which can be interpreted as a version spec, or maybe not.

'git', and 'rev' is very specific to git, but we can add 'svn' later.

@miyagawa
Owner

I mean technically, you can create an HTTP-WebDAV based SVN url that looks like "http://example.com/foo.git".

URLs like git@github.com:foo/bar.git@commithash is very confusing, and cpanm only handles this with the heuristics (i.e. URL should end with .git). It is okay for cpanm's argument parser to be "smart" to handle it as the sanest way as possible, but for cpanfile spec, it's better to be explicit rather than implicit.

@masaki

I see. It is difficult to identify VCS commands from only URL.
I also think so, "it's better to be explicit rather than implicit".

@battlemidget

I didnt see any referenced commits has any progress been made on this issue yet?

@miyagawa
Owner

No.

@battlemidget

Care to elaborate? Are they still in the plans to be included or are you taking a different direction?

@miyagawa
Owner

Yes it will come hopefully soon.

@battlemidget

Any news on this progress?

@miyagawa
Owner

It's supported in the dev version of cpanfile and Carton, with at and git option.

@miyagawa miyagawa closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.