CPAN Testers reporting #184

Open
tobyink opened this Issue Jan 2, 2013 · 5 comments

Comments

Projects
None yet
2 participants

tobyink commented Jan 2, 2013

I've recently released https://metacpan.org/release/App-cpantimes which adds support for CPAN testers reports to cpanminus.

It does a run-time check to see if Test::Reporter and Test::Reporter::Transport::Metabase are available and correctly configured, and if so will send PASS/FAIL reports. If they're unavailable or not configured correctly then it will print a warning but the installation will otherwise continue as normal.

It's not a lot of extra code, and the run-time check means that it adds no additional required dependencies.

Would such an approach be appropriate for adding to cpanminus itself? If so, I can supply a patch. If not, then I'm happy to continue maintaining cpantimes separately.

@miyagawa miyagawa added a commit that referenced this issue Jan 6, 2013

@miyagawa miyagawa Checking in changes prior to tagging of version 1.5017.
Changelog diff is:

diff --git a/Changes b/Changes
index 0e1484d..6685184 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,9 @@
 See http://github.com/miyagawa/cpanminus/ for the latest development.

+1.5017 Wed Jul 18 08:28:49 PDT 2012
+   [Improvements]
+      - Ignore tarballs whose first entry is "./" (doy) #184
+
 1.5016 Tue Jul 17 12:00:57 PDT 2012
    [Improvements]
       - Added Module/CPANfile.pm to the fatlib. This allows bootstrapping dependencies
917a607

@miyagawa miyagawa added a commit that referenced this issue Jan 6, 2013

@miyagawa miyagawa Checking in changes prior to tagging of version 1.5018.
Changelog diff is:

diff --git a/Changes b/Changes
index 6685184..6740d36 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,9 @@
 See http://github.com/miyagawa/cpanminus/ for the latest development.

+1.5018 Wed Sep 19 14:40:28 JST 2012
+   [Improvements]
+      - Check cpanm path upon --self-upgrade to give warnings for perlbrew users
+
 1.5017 Wed Jul 18 08:28:49 PDT 2012
    [Improvements]
       - Ignore tarballs whose first entry is "./" (doy) #184
ee6cd30
Owner

miyagawa commented Feb 1, 2013

I'm interested in how big the patch would be, and if it is a reasonable size and the code is isolated, I'm happy to include it into the core.

(Ignore the commits above it's a wrong issue number referenced in the changelog)

tobyink commented Feb 1, 2013

The guts are contained within a single sub of about 50 lines.

The main places where it needs to couple itself to the existing cpanminus methods are: it caches the result of resolve_name method (because sending a test report requires the CPANID of the author, and the filename of the dist) and it gets called within the test method. It also does a small amount of initialization work in the constructor, but that could be moved elsewhere quite easily. I'd say it's moderately isolated.

Owner

miyagawa commented Feb 1, 2013

Sounds reasonable. I will take a look if you can make pull request out of it. Thanks!

Owner

miyagawa commented Feb 15, 2013

Update with pull req if you want to get this in 1.6 which i plan to release in a few days!

tobyink commented Mar 3, 2013

See also merge request #209.

miyagawa removed the 1.8 label May 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment