New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing from github leaves /tmp dir #219

Closed
oylenshpeegul opened this Issue Mar 16, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@oylenshpeegul

When I do an install from github (of a module that does have a META.yml file), I get a message complaining about the tmp directory

$ cpanm git://github.com/atz/Config-Simple.git
Cloning git://github.com/atz/Config-Simple.git ... OK
--> Working on git://github.com/atz/Config-Simple.git
Configuring Config-Simple-4.60 ... OK
Building and testing Config-Simple-4.60 ... OK
Successfully installed Config-Simple-4.60
cannot remove path when cwd is /tmp/it6rDijaB2 for /tmp/it6rDijaB2:  at /home/tim/perl5/perlbrew/perls/perl-5.16.2/lib/5.16.3/File/Temp.pm line 2445.
1 distribution installed
@miyagawa

This comment has been minimized.

Show comment
Hide comment
@miyagawa

miyagawa Mar 16, 2013

Owner

This looks like a regression from File::Temp 0.23
https://metacpan.org/source/TJENNESS/File-Temp-0.23/ChangeLog

Downgraded to 0.22 and the warning/error is gone.

Owner

miyagawa commented Mar 16, 2013

This looks like a regression from File::Temp 0.23
https://metacpan.org/source/TJENNESS/File-Temp-0.23/ChangeLog

Downgraded to 0.22 and the warning/error is gone.

@oylenshpeegul

This comment has been minimized.

Show comment
Hide comment
@oylenshpeegul

oylenshpeegul Mar 16, 2013

Hm. That doesn't seem to be the case.

$ perl -MFile::Temp -E 'say File::Temp->VERSION'
0.22

Hm. That doesn't seem to be the case.

$ perl -MFile::Temp -E 'say File::Temp->VERSION'
0.22
@miyagawa

This comment has been minimized.

Show comment
Hide comment
@miyagawa

miyagawa Mar 16, 2013

Owner

Not here

> cpanm File::Temp@0.22                              
Successfully installed File-Temp-0.22
1 distribution installed
> cpanm git://github.com/miyagawa/Hash-MultiValue.git
Successfully installed Hash-MultiValue-0.13
1 distribution installed
> cpanm File::Temp@0.23
Successfully installed File-Temp-0.23
1 distribution installed
> cpanm git://github.com/miyagawa/Hash-MultiValue.git
Successfully installed Hash-MultiValue-0.13
cannot remove path when cwd is /private/var/folders/g2/fzfdvxhx5bvdq5y99syc4_fh0000gn/T/re8YYJMDo5 for /private/var/folders/g2/fzfdvxhx5bvdq5y99syc4_fh0000gn/T/re8YYJMDo5:  at /Users/miyagawa/perl5/perlbrew/perls/perl-5.16.2/lib/5.16.2/File/Temp.pm line 2530.
1 distribution installed
Owner

miyagawa commented Mar 16, 2013

Not here

> cpanm File::Temp@0.22                              
Successfully installed File-Temp-0.22
1 distribution installed
> cpanm git://github.com/miyagawa/Hash-MultiValue.git
Successfully installed Hash-MultiValue-0.13
1 distribution installed
> cpanm File::Temp@0.23
Successfully installed File-Temp-0.23
1 distribution installed
> cpanm git://github.com/miyagawa/Hash-MultiValue.git
Successfully installed Hash-MultiValue-0.13
cannot remove path when cwd is /private/var/folders/g2/fzfdvxhx5bvdq5y99syc4_fh0000gn/T/re8YYJMDo5 for /private/var/folders/g2/fzfdvxhx5bvdq5y99syc4_fh0000gn/T/re8YYJMDo5:  at /Users/miyagawa/perl5/perlbrew/perls/perl-5.16.2/lib/5.16.2/File/Temp.pm line 2530.
1 distribution installed
@oylenshpeegul

This comment has been minimized.

Show comment
Hide comment
@oylenshpeegul

oylenshpeegul Mar 17, 2013

Is your tempdir removed? I find I have to leave that directory upon success.

https://github.com/miyagawa/cpanminus/pull/220/files

Is your tempdir removed? I find I have to leave that directory upon success.

https://github.com/miyagawa/cpanminus/pull/220/files

@oylenshpeegul oylenshpeegul reopened this Mar 17, 2013

@miyagawa miyagawa closed this Mar 17, 2013

miyagawa added a commit that referenced this issue Mar 17, 2013

Checking in changes prior to tagging of version 1.6007.
Changelog diff is:

diff --git a/Changes b/Changes
index a09af7b..25d4ab7 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 See http://github.com/miyagawa/cpanminus/ for the latest development.

+1.6007  Sun Mar 17 14:26:07 PDT 2013
+   [Improvements]
+      - Fixed a warning where temp directory created with git install doesn't actually
+        cleanup the temporary directory. (Tim Heaney) #219
+
 1.6006  Wed Mar 13 22:53:44 PDT 2013
    [Improvements]
       - Fixed --save-dists option when used with non-CPAN distros. They're now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment