Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take care of zipfiles that have comments #560

Merged
merged 1 commit into from Feb 12, 2018

Conversation

@skaji
Copy link
Contributor

skaji commented Feb 11, 2018

Fix #559

As described in #559, unzip -t zipfile may have some comment lines.

❯ wget -q http://www.cpan.org/authors/id/J/JJ/JJONES/Finance-OFX-Parse-Simple-0.07.zip

❯ unzip -t Finance-OFX-Parse-Simple-0.07.zip
Archive:  Finance-OFX-Parse-Simple-0.07.zip
f5019eed24b24c4cb8de55c5db3384aa9d251f09
    testing: Finance--OFX--Parse--Simple-master/   OK
    testing: Finance--OFX--Parse--Simple-master/Changes   OK
    testing: Finance--OFX--Parse--Simple-master/MANIFEST   OK
    testing: Finance--OFX--Parse--Simple-master/META.yml   OK
    testing: Finance--OFX--Parse--Simple-master/Makefile.PL   OK
    testing: Finance--OFX--Parse--Simple-master/README   OK
    testing: Finance--OFX--Parse--Simple-master/README.md   OK
    testing: Finance--OFX--Parse--Simple-master/lib/   OK
    testing: Finance--OFX--Parse--Simple-master/lib/Finance/   OK
    testing: Finance--OFX--Parse--Simple-master/lib/Finance/OFX/   OK
    testing: Finance--OFX--Parse--Simple-master/lib/Finance/OFX/Parse/   OK
    testing: Finance--OFX--Parse--Simple-master/lib/Finance/OFX/Parse/Simple.pm   OK
    testing: Finance--OFX--Parse--Simple-master/t/   OK
    testing: Finance--OFX--Parse--Simple-master/t/00-load.t   OK
    testing: Finance--OFX--Parse--Simple-master/t/01-main.t   OK
    testing: Finance--OFX--Parse--Simple-master/t/pod-coverage.t   OK
    testing: Finance--OFX--Parse--Simple-master/t/pod.t   OK
No errors detected in compressed data of Finance-OFX-Parse-Simple-0.07.zip.

This PR change the code to retry the detection of root directory.

@miyagawa miyagawa merged commit 86073a7 into miyagawa:devel Feb 12, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.