ENH: Adds license message on first import #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems travis complains: https://travis-ci.org/miykael/atlasreader/jobs/435401380#L862 Do we need to include an additional test that does an empty import first to get rid of the license message? |
|
Huh, weird. I'll try and take a look at this in a few days -- I've got a fellowship application due Wednesday so will be off-the-grid until then... Sorry!! |
|
I've changed something but it created new problems... @rmarkello do you have any idea how to solve this issue? |
|
Locally all the tests pass. Will merge this. |
This was referenced Jan 8, 2019
miykael
added a commit
that referenced
this pull request
Jan 8, 2019
Add license text from PR #71 to __init__
|
Those changes were finally implemented with #88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first time
atlasreaderis imported a message is printed describing licensing details and pointing users to the repository for more information.Not sure if this should go in
__init__.pyor in autils.pyand be called in__init__.py, but let me know your thoughts!