Sync Volar 1.9#7
Conversation
|
Thank you! I was going to update Volar.js too, but didn't have time to do it. So sending me the PR helps me a lot. I will check the PR now. |
| } | ||
| return target[property]; | ||
| }, | ||
| }); |
There was a problem hiding this comment.
I am glad to remove many of the codes :)
|
I found a problem with newly added assets not being suggested due to forgetting to implement Other than that, there seems to be no problem. It matches my needs well enough. Thanks! @johnsoncodehk |
|
I will merge this PR if it is ok with you. |
|
Hi, what problems can it cause if we don't implement |
|
If the patch db48182 is not included, the added assets will not be suggested. How to reproduce: $ git checkout 6c19f97
$ npm run build
$ # Open example project with VS Code
$ cd examples/nextjs
$ code .2023-07-26.0.23.26.movIf the patch is included, the added assets are also suggested. 2023-07-26.0.32.19.mov |
|
Thanks! I'll investigate how to fix it from the framework, before that I think we can merge this PR, as the change is probably just an implementation improvement rather than a bug fix. |
|
It sounds good that Volar.js would take care of it 👍. I'll merge this PR for now. Thanks for the contribution! |
Hi, I tried to make the required changes for the TS Plugin integration updated to Volar 1.9, can you see if it matches your original needs? Thanks.