New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify subject type explicitly #105

Merged
merged 5 commits into from May 17, 2013

Conversation

Projects
None yet
1 participant
@mizzy
Owner

mizzy commented May 16, 2013

This is the implementation of #104 and working in progress.

This works fine except one point.

be_enabled matcher is prior to Serverspec::Type::Service.enabled?.

So I must remove the definition of be_enabled matcher.

But I'd like to keep matcher definitions remain for a while for backward compatibility.

mizzy added some commits May 16, 2013

Add specs for service type subject
Also fixed how to include modules and how to run specs.

The syntax ``:os => :xxx`` doesn't work with eplicit typed subjects.

So I separete specs into per OS and include OS helpers explicitly
@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy May 17, 2013

Owner

I've finished implementing service type.So I will merge and release it.

Owner

mizzy commented May 17, 2013

I've finished implementing service type.So I will merge and release it.

mizzy added a commit that referenced this pull request May 17, 2013

@mizzy mizzy merged commit 4476f8f into master May 17, 2013

1 check passed

default The Travis CI build passed
Details

@mizzy mizzy deleted the explicit-subject-type branch May 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment