New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix be_mode and be_executable matcher to be compatible with Mac OS X v10.4.11 #127

Merged
merged 2 commits into from May 25, 2013

Conversation

Projects
None yet
2 participants
@matsuo
Contributor

matsuo commented May 23, 2013

Update check_mode and get_mode methods for Darwin because "stat -f %A" is not available on Mac OS X v10.4.11. This pull request works for me on Mac OS X v10.4.11.

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy May 25, 2013

"stat -f%Lp #{escape(file)} | grep -- #{escape(regexp)" would be better.

mizzy commented on lib/serverspec/commands/darwin.rb in bf359f8 May 25, 2013

"stat -f%Lp #{escape(file)} | grep -- #{escape(regexp)" would be better.

@matsuo

This comment has been minimized.

Show comment
Hide comment
@matsuo

matsuo May 25, 2013

Contributor

Thanks. I think so, too. I have updated and tested with v10.4.11, v10.5.8, v10.6.8, v10.7.5, v10.8.3.

Contributor

matsuo commented May 25, 2013

Thanks. I think so, too. I have updated and tested with v10.4.11, v10.5.8, v10.6.8, v10.7.5, v10.8.3.

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy May 25, 2013

Owner

Thanks!

Owner

mizzy commented May 25, 2013

Thanks!

mizzy added a commit that referenced this pull request May 25, 2013

Merge pull request #127 from matsuo/darwin-support
Fix be_mode and be_executable matcher to be compatible with Mac OS X v10.4.11

@mizzy mizzy merged commit e72b08f into mizzy:master May 25, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment