Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debian service detection #130

Merged
merged 2 commits into from Jun 13, 2013
Merged

Conversation

@cs-travis
Copy link
Contributor

@cs-travis cs-travis commented May 27, 2013

  • check_enabled now understands upstart (enough to
    check whether services start on boot)
  • check_running now properly uses /usr/sbin/service
* check_enabled now understands upstart (enough to
  check whether services start on boot)

* check_running now properly uses /usr/sbin/service
@mizzy
Copy link
Owner

@mizzy mizzy commented May 27, 2013

Thanks @cs-travis . Looks good to me.

But tests are failing.So you should also fix spec/debian/commands_spec.rb.

You can run tests with the command rake spec locally.

And please change /usr/sbin/service to service.Because I changed serverspec to use relative path in #129 .

* Modified spec/debian/commands_spec.rb to check for new commands
* Changed absolute paths to relative because mizzy#129
@bobziuchkovski
Copy link

@bobziuchkovski bobziuchkovski commented Jun 13, 2013

+1 Ran into this upstart service detection issue. I pulled cs-travis' commit 400a50c and it works as expected.

mizzy added a commit that referenced this issue Jun 13, 2013
@mizzy mizzy merged commit 3a4308e into mizzy:master Jun 13, 2013
1 check passed
@mizzy
Copy link
Owner

@mizzy mizzy commented Jun 13, 2013

Sorry for merging too late.I've missed the additional commit.

@bobziuchkovski
Copy link

@bobziuchkovski bobziuchkovski commented Jun 13, 2013

Np, thanks for the current merge.

@mizzy
Copy link
Owner

@mizzy mizzy commented Jun 13, 2013

I've released as v0.6.1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants