Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package installed by pecl #157

Merged
merged 2 commits into from Jun 20, 2013
Merged

add package installed by pecl #157

merged 2 commits into from Jun 20, 2013

Conversation

@kotakanbe
Copy link
Contributor

@kotakanbe kotakanbe commented Jun 19, 2013

No description provided.

@mizzy
Copy link
Owner

@mizzy mizzy commented Jun 19, 2013

Thanks for your patch.

Please add tests to spec/<os_name>/commands_spec.rb.

@kotakanbe
Copy link
Contributor Author

@kotakanbe kotakanbe commented Jun 20, 2013

I found that spec/commands_spec.rb do'nt have check_installed_by_npm testcase.

@mizzy
Copy link
Owner

@mizzy mizzy commented Jun 20, 2013

I found that spec/commands_spec.rb do'nt have check_installed_by_npm testcase.

Thanks! I will add them.

mizzy added a commit that referenced this issue Jun 20, 2013
@mizzy mizzy merged commit 5206da6 into mizzy:master Jun 20, 2013
1 check passed
@kotakanbe kotakanbe deleted the package-installed-by-pecl branch Jun 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants