New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package installed by pecl #157

Merged
merged 2 commits into from Jun 20, 2013

Conversation

Projects
None yet
2 participants
@kotakanbe
Contributor

kotakanbe commented Jun 19, 2013

No description provided.

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Jun 19, 2013

Owner

Thanks for your patch.

Please add tests to spec/<os_name>/commands_spec.rb.

Owner

mizzy commented Jun 19, 2013

Thanks for your patch.

Please add tests to spec/<os_name>/commands_spec.rb.

@kotakanbe

This comment has been minimized.

Show comment
Hide comment
@kotakanbe

kotakanbe Jun 20, 2013

Contributor

I found that spec/commands_spec.rb do'nt have check_installed_by_npm testcase.

Contributor

kotakanbe commented Jun 20, 2013

I found that spec/commands_spec.rb do'nt have check_installed_by_npm testcase.

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Jun 20, 2013

Owner

I found that spec/commands_spec.rb do'nt have check_installed_by_npm testcase.

Thanks! I will add them.

Owner

mizzy commented Jun 20, 2013

I found that spec/commands_spec.rb do'nt have check_installed_by_npm testcase.

Thanks! I will add them.

mizzy added a commit that referenced this pull request Jun 20, 2013

@mizzy mizzy merged commit 5206da6 into mizzy:master Jun 20, 2013

1 check passed

default The Travis CI build passed
Details

@kotakanbe kotakanbe deleted the kotakanbe:package-installed-by-pecl branch Jun 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment