New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper grammer for be_a #159

Merged
merged 1 commit into from Jun 22, 2013

Conversation

Projects
None yet
2 participants
@ijin
Contributor

ijin commented Jun 21, 2013

No description provided.

@ijin

This comment has been minimized.

Show comment
Hide comment
@ijin

ijin Jun 21, 2013

Contributor

"should be_a_file" makes more grammatical sense than "should be_file"
ditto for be_directory and be_socket.

I made it an alias method for backward compatibility.

Contributor

ijin commented Jun 21, 2013

"should be_a_file" makes more grammatical sense than "should be_file"
ditto for be_directory and be_socket.

I made it an alias method for backward compatibility.

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Jun 21, 2013

Owner

I omit a intentionally because it is verbose, but it is good to be able to choose both syntax.

I found that should be_a_file also calls file? method, not a_file? method.
So it is not need to define alias.(Other matchers are same, too.)

I will merge your commits other than lib/serverspec/type/file.rb.

Thanks!

Owner

mizzy commented Jun 21, 2013

I omit a intentionally because it is verbose, but it is good to be able to choose both syntax.

I found that should be_a_file also calls file? method, not a_file? method.
So it is not need to define alias.(Other matchers are same, too.)

I will merge your commits other than lib/serverspec/type/file.rb.

Thanks!

@mizzy mizzy merged commit eeff2b9 into mizzy:master Jun 22, 2013

1 check passed

default The Travis CI build passed
Details
@ijin

This comment has been minimized.

Show comment
Hide comment
@ijin

ijin Jun 22, 2013

Contributor

Thanks! It might be good if there's some mention of this in the docs.

Contributor

ijin commented Jun 22, 2013

Thanks! It might be good if there's some mention of this in the docs.

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Jun 22, 2013

Owner

I see.

Owner

mizzy commented Jun 22, 2013

I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment