New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect FreeBSD for beginning to support it. #161

Merged
merged 5 commits into from Sep 24, 2013

Conversation

Projects
None yet
2 participants
@hfm
Copy link
Contributor

hfm commented Jun 23, 2013

Hello, Mr. mizzy.

I added some files for detecting FreeBSD because I'm fond of it 馃槂
I'm going to write a test (spec files) next.

module Serverspec
module Commands
class FreeBSD < Base
class NotImplementedError < Exception; end

This comment has been minimized.

@mizzy

mizzy Jun 23, 2013

Owner

NotImplementedError class is defined in Base class, so this is not needed.

(Linux class and Darwin class also have this class, but they are wrong.So I will fix them.)

@hfm

This comment has been minimized.

Copy link
Contributor

hfm commented Jun 23, 2013

I fixed it!
Thank you very much.

module Serverspec
module Commands
class FreeBSD < Base
def check_enabled service

This comment has been minimized.

@mizzy

mizzy Jun 23, 2013

Owner

I've fixed all of the methods to use parentheses according to Ruby Styleguide just now.

So please add parentheses.

"pkg_version -X -s #{escape(package)}"
end

def check_listening port

This comment has been minimized.

@mizzy

mizzy Jun 23, 2013

Owner

Add parentheses, please.

"service -e | grep -- #{escape(service)}"
end

def check_installed package

This comment has been minimized.

@mizzy

mizzy Jun 23, 2013

Owner

Add parentheses, please.

@hfm

This comment has been minimized.

Copy link
Contributor

hfm commented Jun 23, 2013

I completed adding parentheses.

@mizzy

This comment has been minimized.

Copy link
Owner

mizzy commented Jun 23, 2013

Thanks.

I will merge your patches after you putting tests.

You should send patches and its tests at same time.Without tests, I can't sure your patches work correctly.

Please send both patches and its tests at same time next time.

@mizzy mizzy merged commit 9efd1af into mizzy:master Sep 24, 2013

1 check passed

default The Travis CI build passed
Details
@mizzy

This comment has been minimized.

Copy link
Owner

mizzy commented Sep 24, 2013

Merged, added specs and released as v0.9.3.Thanks.

@hfm hfm deleted the hfm:freebsd branch Dec 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment