New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `-s sh` of check_access command #168

Merged
merged 1 commit into from Jun 26, 2013

Conversation

Projects
None yet
2 participants
@mizzy
Owner

mizzy commented Jun 26, 2013

It's not allowed to execute because it's not full path and it's not needed.

Remove `-s sh` of check_access command
It's not allowed to execute because it's not full path and it's not needed.

mizzy added a commit that referenced this pull request Jun 26, 2013

Merge pull request #168 from mizzy/omit-s-option
Remove `-s sh` of check_access command

@mizzy mizzy merged commit 7eae77d into master Jun 26, 2013

1 check passed

default The Travis CI build passed
Details

@mizzy mizzy deleted the omit-s-option branch Jun 26, 2013

@sohgo

This comment has been minimized.

Show comment
Hide comment
@sohgo

sohgo Aug 6, 2013

Contributor

I think "-s sh" is necessary (it should be -s /bin/sh) because the login shell of some users (e.g. daemon program and/or system users) can be /usr/sbin/nologin and/or /bin/false etc. If these login shells are used, the test will always fail.

Any comments are appreciated.

Contributor

sohgo commented Aug 6, 2013

I think "-s sh" is necessary (it should be -s /bin/sh) because the login shell of some users (e.g. daemon program and/or system users) can be /usr/sbin/nologin and/or /bin/false etc. If these login shells are used, the test will always fail.

Any comments are appreciated.

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Aug 6, 2013

Owner

Thanks.You're right.

If you will fix them and send me a pull request, I will very appreciate it and merge it.

Owner

mizzy commented Aug 6, 2013

Thanks.You're right.

If you will fix them and send me a pull request, I will very appreciate it and merge it.

@sohgo

This comment has been minimized.

Show comment
Hide comment
@sohgo

sohgo Aug 6, 2013

Contributor

Thanks for your comment. I will send a pull request later.

Contributor

sohgo commented Aug 6, 2013

Thanks for your comment. I will send a pull request later.

@sohgo sohgo referenced this pull request Aug 7, 2013

Merged

Revert and fix pull #168 #226

mizzy added a commit that referenced this pull request Aug 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment