Support rpm on be_installed` matcher #203
Merged
Conversation
Thanks. You should use alias method rather than defining a new method like this. def check_installed(package,version=nil)
cmd = "rpm -q #{escape(package)}"
if ! version.nil?
cmd = "#{cmd} | grep -w -- #{escape(version)}"
end
cmd
end
alias :check_installed_by_rpm :check_installed |
Just as you say. I revert and reimplement by alias. |
Thanks! |
mizzy
added a commit
that referenced
this pull request
Jul 5, 2013
Support rpm on be_installed` matcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This pull request following test.
until apply this patch, following result.