Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert and fix pull #168 #226

Merged
merged 3 commits into from Aug 7, 2013
Merged

Revert and fix pull #168 #226

merged 3 commits into from Aug 7, 2013

Conversation

@sohgo
Copy link
Contributor

@sohgo sohgo commented Aug 7, 2013

This is a pull request that I mentioned here #168 (comment)
I am new to serverspec. I would appreciate if you review my code.
Thank you.

Sohgo Takeuchi added 3 commits Aug 7, 2013
This reverts commit 19a852a.

The -s "sh" option to su command on Linux systems is necessary
because if the login shell of a user specified to the su command
is /bin/false or /usr/sbin/nologin etc, the tests will always fail.
@mizzy
Copy link
Owner

@mizzy mizzy commented Aug 7, 2013

Thanks a lot! Looks good to me.

mizzy added a commit that referenced this issue Aug 7, 2013
@mizzy mizzy merged commit 6ab9525 into mizzy:master Aug 7, 2013
1 check passed
@sohgo
Copy link
Contributor Author

@sohgo sohgo commented Aug 7, 2013

Thanks for your work.

@mizzy
Copy link
Owner

@mizzy mizzy commented Aug 7, 2013

Released as v0.7.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants