Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the exec backend return proper exitstatus. #262

Merged
merged 1 commit into from Oct 8, 2013

Conversation

@ryotarai
Copy link
Contributor

@ryotarai ryotarai commented Oct 8, 2013

Before this pull request, Serverspec::Backend::Exec#run_command returns $? as exit status.
$? is an instance of Process::Status.

If $? is compared with an interger, $?.to_i will be compared with the value.
Process::Status#to_i doesn't return exit status but returns the bits in the status as Fixnum.

c.f.) http://www.ruby-doc.org/core-2.0.0/Process/Status.html

mizzy added a commit that referenced this issue Oct 8, 2013
Make the exec backend return proper exitstatus.
@mizzy mizzy merged commit 61465cb into mizzy:master Oct 8, 2013
1 check failed
@mizzy
Copy link
Owner

@mizzy mizzy commented Oct 8, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants