Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ps command to show more data to match. #28

Merged
merged 1 commit into from Apr 3, 2013
Merged

Change ps command to show more data to match. #28

merged 1 commit into from Apr 3, 2013

Conversation

@darron
Copy link
Contributor

@darron darron commented Apr 3, 2013

ps -e doesn't show enough data to match if the process name doesn't exactly match - this shows more data.

For example:

describe 'jetty' do
  it { should be_enabled }
  it { should be_running }
end

It shows as being enabled but it never shows as running because it's running under Java. This is the command for jetty:

/usr/bin/java -Dsolr.solr.home=/opt/solr -Djetty.port=8085 -Djetty.home=/opt/jetty -Djava.io.tmpdir=/tmp -jar /opt/jetty/start.jar --pre=etc/jetty-logging.xml --daemon

I'm not sure how cross platform this change is.

ps -e doesn't show enough data to match if the process name doesn't exactly match - this shows more data.
mizzy added a commit that referenced this issue Apr 3, 2013
Change ps command to show more data to match.
@mizzy mizzy merged commit 05b25c1 into mizzy:master Apr 3, 2013
1 check failed
Loading
mizzy added a commit that referenced this issue Apr 3, 2013
@mizzy
Copy link
Owner

@mizzy mizzy commented Apr 3, 2013

Thanks. I've merged and released as v0.1.3.

Loading

@darron
Copy link
Contributor Author

@darron darron commented Apr 3, 2013

Perfect - thanks! Works great now!

[master] darron@~/Desktop/solr: rake spec
/Users/darron/.rbenv/versions/1.9.3-p392/bin/ruby -S rspec spec/solr-berkshelf/jetty_spec.rb
.....

Finished in 0.16861 seconds
5 examples, 0 failures

Loading

@mizzy
Copy link
Owner

@mizzy mizzy commented Apr 3, 2013

👍

Loading

@darron
Copy link
Contributor Author

@darron darron commented Apr 3, 2013

There is a problem - it matches the grep process now and so doesn't notice if the process dies.

Working on a fix.

Loading

@mizzy
Copy link
Owner

@mizzy mizzy commented Apr 3, 2013

Oh, I see.Thanks for working on a fix.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants