Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support comparing versions of packages. #315

Merged
merged 1 commit into from Dec 17, 2013

Conversation

@ryotarai
Copy link
Contributor

@ryotarai ryotarai commented Dec 17, 2013

You can write a spec like the following:

describe package('httpd') do
  its(:version) { should > '2.2.14' }
end
@mizzy
Copy link
Owner

@mizzy mizzy commented Dec 17, 2013

Very useful!

mizzy added a commit that referenced this issue Dec 17, 2013
Support comparing versions of packages.
@mizzy mizzy merged commit 787359f into mizzy:master Dec 17, 2013
1 check passed
@vincentbernat
Copy link
Contributor

@vincentbernat vincentbernat commented Dec 17, 2013

Unfortunately, Gem::Version is rather limited to what it accepts. Most distributions will use versions like 1.2.3-10 which won't be accepted by Gem::Version.

@mizzy
Copy link
Owner

@mizzy mizzy commented Dec 17, 2013

I see.

I will revert this merge. How do you think, @ryotarai ?

@vincentbernat
Copy link
Contributor

@vincentbernat vincentbernat commented Dec 17, 2013

Please wait a few minutes, I will propose an alternative.

@vincentbernat
Copy link
Contributor

@vincentbernat vincentbernat commented Dec 17, 2013

See pull request #316. Bear in mind that I am an absolute beginner with Ruby. Maybe there is a more elegant way to do the same thing!

@ryotarai
Copy link
Contributor Author

@ryotarai ryotarai commented Dec 18, 2013

@mizzy @vincentbernat
Pull request #316 looks good to me!
But it seems to contain a typo. I commented on #316 .

@mizzy
Copy link
Owner

@mizzy mizzy commented Mar 27, 2014

Released as v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants