Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Serverspec::Type::Package::Version. #317

Merged
merged 2 commits into from Dec 18, 2013

Conversation

@ryotarai
Copy link
Contributor

@ryotarai ryotarai commented Dec 18, 2013

  • To make more object-oriented, I changed arity of Version#ver_array
  • Remove #dup because the instance is not modified in the method.
@vincentbernat
Copy link
Contributor

@vincentbernat vincentbernat commented Dec 18, 2013

Yes, the .dup was a leftover of a previous more complex version.

@mizzy
Copy link
Owner

@mizzy mizzy commented Dec 18, 2013

Thanks!

mizzy added a commit that referenced this issue Dec 18, 2013
Refactor Serverspec::Type::Package::Version.
@mizzy mizzy merged commit 5d8b89d into mizzy:master Dec 18, 2013
1 check passed
@mizzy
Copy link
Owner

@mizzy mizzy commented Mar 27, 2014

Released as v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants