New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change regex to match more vagrant machine names #334

Merged
merged 1 commit into from Jan 22, 2014

Conversation

Projects
None yet
2 participants
@kaorimatz
Contributor

kaorimatz commented Jan 21, 2014

serverspec-init recognizes /[a-z_-]+/ as vagrant machine name.
So, it cannot recognize machine name that contains digits or uppercase letters :

$ cat Vagrantfile
Vagrant.configure('2') do |config|
  config.vm.define 'app1'
  config.vm.define 'DB'
end
$ serverspec-init
...
Vagrant instance y/n: y
Auto-configure Vagrant from Vagrantfile? y/n: y
0) not
1) not

This pull request updates vagrant machine name regex to support name that contains digits or uppercase letters.

Change regex to match more vagrant machine names
Support machine name that contains digits or uppercase letters.

mizzy added a commit that referenced this pull request Jan 22, 2014

Merge pull request #334 from kaorimatz/vagrant-machine-name-regex
Change regex to match more vagrant machine names

@mizzy mizzy merged commit 22ed606 into mizzy:master Jan 22, 2014

1 check passed

default The Travis CI build passed
Details
@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Jan 22, 2014

Owner

Thanks!

Owner

mizzy commented Jan 22, 2014

Thanks!

@kaorimatz kaorimatz deleted the kaorimatz:vagrant-machine-name-regex branch Feb 26, 2014

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Mar 27, 2014

Owner

Released as v1.0.0.

Owner

mizzy commented Mar 27, 2014

Released as v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment