add zfs matcher #40

Merged
merged 1 commit into from Apr 8, 2013

Conversation

Projects
None yet
2 participants
@ftnk
Contributor

ftnk commented Apr 7, 2013

I've added zfs matcher.

Usage

describe 'rpool' do

ZFS 'rpool' should exist

it { should be_zfs }

property 'mountpoint' of ZFS 'rpool' should be '/rpool'

it { should be_zfs('/rpool').property('mountpoint') }

property 'quota' of ZFS 'rpool' should be 'none'

it { should be_zfs('none').property('quota') }

property 'compression' of ZFS 'rpool' should be 'off'

it { should be_zfs('off').property('compression')}
end

@mizzy mizzy merged commit 471c9b1 into mizzy:master Apr 8, 2013

1 check failed

default The Travis build failed
Details
@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Apr 8, 2013

Owner

I've merged and fixed some points.

  • Fixed to adapt to specification changes of #36
  • Fixed some specs
  • be_zfs(value).property(property) is unnatural, so fixed it to be_zfs.with({ property => value })

Please see 425349b and 09e3227 .
I confirmed that all specs are passed, but did not confirmed on Solaris.
So please check them on Solaris.

If there will be no problem, I will released as v0.2.2.

Thanks.

Owner

mizzy commented Apr 8, 2013

I've merged and fixed some points.

  • Fixed to adapt to specification changes of #36
  • Fixed some specs
  • be_zfs(value).property(property) is unnatural, so fixed it to be_zfs.with({ property => value })

Please see 425349b and 09e3227 .
I confirmed that all specs are passed, but did not confirmed on Solaris.
So please check them on Solaris.

If there will be no problem, I will released as v0.2.2.

Thanks.

@ftnk

This comment has been minimized.

Show comment
Hide comment
@ftnk

ftnk Apr 8, 2013

Contributor

Thank you for merge and fix.

It works fine on Solaris.

but I found be_zfs.with is not strict. "be_zfs.with({'compression' =>
'on'})" never fail, because 'on' matches
'compression'.

% zfs get -H compression rpool |grep on
rpool compression off default

I'll fix it later.

2013/4/8 Gosuke Miyashita notifications@github.com

I've merged and fixed some points.

  • Fixed to adapt to specification changes of #36#36
  • Fixed some specs
  • be_zfs(value).property(property) is unnatural, so fixed it to
    be_zfs.with({ property => value })

I confirmed that all specs are passed, but did not confirmed on Solaris.
So please check them on Solaris.

If there will be no problem, I will released as v0.2.2.

Thanks.


Reply to this email directly or view it on GitHubhttps://github.com/mizzy/serverspec/pull/40#issuecomment-16030134
.

Contributor

ftnk commented Apr 8, 2013

Thank you for merge and fix.

It works fine on Solaris.

but I found be_zfs.with is not strict. "be_zfs.with({'compression' =>
'on'})" never fail, because 'on' matches
'compression'.

% zfs get -H compression rpool |grep on
rpool compression off default

I'll fix it later.

2013/4/8 Gosuke Miyashita notifications@github.com

I've merged and fixed some points.

  • Fixed to adapt to specification changes of #36#36
  • Fixed some specs
  • be_zfs(value).property(property) is unnatural, so fixed it to
    be_zfs.with({ property => value })

I confirmed that all specs are passed, but did not confirmed on Solaris.
So please check them on Solaris.

If there will be no problem, I will released as v0.2.2.

Thanks.


Reply to this email directly or view it on GitHubhttps://github.com/mizzy/serverspec/pull/40#issuecomment-16030134
.

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Apr 8, 2013

Owner

but I found be_zfs.with is not strict. "be_zfs.with({'compression' =>
'on'})" never fail, because 'on' matches
'compression'.

% zfs get -H compression rpool |grep on
rpool compression off default

I've fixed that in #41 .Please check it.

Owner

mizzy commented Apr 8, 2013

but I found be_zfs.with is not strict. "be_zfs.with({'compression' =>
'on'})" never fail, because 'on' matches
'compression'.

% zfs get -H compression rpool |grep on
rpool compression off default

I've fixed that in #41 .Please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment