New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lib/serverspec/commands/linux.rb #89

Merged
merged 1 commit into from May 6, 2013

Conversation

Projects
None yet
2 participants
@ftnk
Copy link
Contributor

ftnk commented May 6, 2013

I've added lib/serverspec/commands/linux.rb
and devided commands depending on Linux into it.

lib/serverspec/commands/{readhat,debian,gentoo}.rb inherits lib/serverspec/commands/linux.rb instead of lib/serverspec/commands/base.rb.

  • commands not depending on OS and distribusion should be defined on lib/serverspec/commands/base.rb
  • commands depending on LInux (like SELinux and iptables) should be defined on lib/serverspec/commands/base.rb
  • commands depending on Distribusion should be defined on lib/serverspec/commands/redhat.rb and so on.

The reason for this is here.
https://twitter.com/ftnk/status/328361052821667840

@mizzy

This comment has been minimized.

Copy link
Owner

mizzy commented May 6, 2013

LGTM. Thanks a lot !

mizzy added a commit that referenced this pull request May 6, 2013

Merge pull request #89 from ftnk/commands-depending-on-linux
add lib/serverspec/commands/linux.rb

@mizzy mizzy merged commit fd5227d into mizzy:master May 6, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment