New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32_Product call replaced with registry key search #43

Merged
merged 1 commit into from Jan 29, 2014

Conversation

Projects
None yet
2 participants
@elmundio87
Contributor

elmundio87 commented Jan 27, 2014

  1. Get-WmiObject Win32_Product is REALLY slow when you have lots of programs installed
  2. The Win32_Product class works by enumerating every MSI package that is installed on the system. When a package is touched, it performs a reconfiguration where the application is validated (and repaired if found to be inconsistent with the original MSI). Serverspec should not be modifying the target machine, only testing its state.
  3. The list that Win32_product produces is incomplete. For example, it is unable to find Google Chrome when it is present in "Add/Remove programs"

(Resubmitted after creating a feature branch)

Win32_Product call replaced with registry key search
1) Get-WmiObject Win32_Product is REALLY slow when you have lots of programs installed
2) The Win32_Product class works by enumerating every MSI package that is installed on the system. When a package is touched, it performs a reconfiguration where the application is validated (and repaired if found to be inconsistent with the original MSI). Serverspec should not be modifying the target machine, only testing its state.
3) The list that Win32_product produces is incomplete. For example, it is unable to find Google Chrome when it is present in "Add/Remove programs"

mizzy added a commit that referenced this pull request Jan 29, 2014

Merge pull request #43 from elmundio87/windows-package-use-registry
Win32_Product call replaced with registry key search

@mizzy mizzy merged commit c683798 into mizzy:master Jan 29, 2014

1 check passed

default The Travis CI build passed
Details
@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Jan 29, 2014

Owner

Thanks.Just released as v0.5.1.

Owner

mizzy commented Jan 29, 2014

Thanks.Just released as v0.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment