Ensure the matched port is listening #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow matching on ipv6 local
|
Thanks! |
|
Released as v2.82.16. |
matt-richardson
added a commit
to OctopusDeploy/OctopusDSC
that referenced
this pull request
Apr 30, 2020
Now we have better "is port not listening" test in serverspec with mizzy/specinfra#716, we can uncomment some tests that weren't working so well due to ports on windows staying in a TIME_WAIT state.
matt-richardson
added a commit
to OctopusDeploy/OctopusDSC
that referenced
this pull request
Apr 30, 2020
Now we have better "is port not listening" test in serverspec with mizzy/specinfra#716, we can uncomment some tests that weren't working so well due to ports on windows staying in a TIME_WAIT state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids matching against a port that is in TIME_WAIT or other non-listening states
Also, allow matching on ipv6 local