Permalink
Commits on Jan 19, 2015
  1. README: fix link text

    Extends a hyperlink to cover the whole line
    
    PR-URL: #8972
    Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
    frankcash committed with geek Jan 5, 2015
Commits on Jan 16, 2015
  1. Merge remote-tracking branch 'upstream/v0.12'

    Conflicts:
    	src/node_version.h
    tjfontaine committed Jan 16, 2015
  2. test: debug-signal-cluster should not be racey

    unref one superfluous timer (as the test suite already has a global
    timeout), and improve the state machine to iterate the messages more
    reliably.
    
    Ultimately make the test complete more quickly.
    
    Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
    tjfontaine committed with misterdjules Jan 15, 2015
  3. cluster: avoid race enabling debugger in worker

    Previously if a worker's state machine had already transitioned into the
    'listening' state when it received the message enabling the debugger,
    the worker would never enable its debugger.
    
    Change the logic to allow the 'listening' as a valid state for enabling
    the debugger.
    
    Fixes #6440
    
    Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
    tjfontaine committed with misterdjules Jan 15, 2015
Commits on Jan 15, 2015
  1. path: don't lower-cases drive letters

    In general path functions don't change the case of a path. Making an
    exception for windows drive letters violates the principle of least
    surprise.
    
    Changing the drive letter case has caused a lot of issues, including
    nodejs/node-v0.x-archive#7031, nodejs/node-v0.x-archive#7806 and lots of bikeshedding about
    whether uppercase is the right case or lowercase.
    
    This effectively reverts nodejs/node-v0.x-archive@a05f973
    
    Reviewed-by: Alexis Campailla <alexis@janeasystems.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    piscisaureus committed with misterdjules Dec 23, 2014
  2. build: add small-icu support for binary packages

    Invokes the configure script used to build binary packages
    (OSX pkg, binary tarballs, pkgsrc, MSI) with --download=all
    --with-intl=small-icu.
    
    Also makes PACKAGEMAKER customizable, because PackageMaker is not
    necessarily installed in /Developer on OSX anymore.
    
    Tested all binary packages on Windows, OSX, Linux and SmartOS.
    
    Fixes #7676.
    
    Reviewed-by: Steven R. Loomis <srl@icu-project.org>
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    misterdjules committed Jan 7, 2015
  3. test: fix ssl/tls options matrix test

    The tests suite available in test/external/ssl-options was originally
    written for security fixes made in the v0.10 branch. In this branch, the
    client's default ciphers list is compatible with SSLv2.
    
    After merging this change from v0.10 to v0.12, this tests suite was
    broken because commits 5d2aef1 and
    f4c8020 make SSL/TLS clients use a
    default ciphers list that is not compatible with the SSLv2 protocol.
    
    This change fixes two issues:
    1) The cipher list that was setup for a given test was not passed
    properly to the client.
    2) When either or both of clients/servers were using SSLv2, tests were
    expected to succeed when at least the server end was using SSLv2
    compatible ciphers. Now, tests are expected to succeed only if
    SSLv2 compatible ciphers are used on both ends.
    
    Fixes #9020.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    misterdjules committed Jan 14, 2015
  4. test: fix test-crypto-stream.js

    A recent merge of v0.10 to v0.12
    (0c7f6ca) upgraded OpenSSL to version
    1.0.1j. In v0.10, this required test-crypto-stream.js to be fixed with
    commit 707cc25. Basically, instead of
    returning the proper error, Err_get_error() would return 0 and the test
    for the error message needed to be updated in test-crypto-stream.js.
    
    However, in the v0.12 branch, crypto error messages are handled a bit
    differently since commit 26a1b71
    landed. Instead of returning the default OpenSSL error message, it makes
    the decipher stream return a default message specific to Node.js.
    
    This commit updates test-crypto-stream.js to test the error object
    against the proper default error message.
    
    Fixes #9019.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    misterdjules committed Jan 14, 2015
  5. cluster: don't assert if worker has no handles

    Do not assume that all workers share all shared handles.
    
    Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
    sam-github committed with misterdjules Oct 29, 2014
  6. cluster: cluster.disconnect() should check status

    Workers that are already disconnected but not yet exited should not be
    disconnected, trying to do so raises exceptions.
    
    Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
    sam-github committed with misterdjules Dec 10, 2014
Commits on Jan 14, 2015
  1. Merge remote-tracking branch 'upstream/v0.10' into v0.12

    Conflicts:
    	test/simple/test-child-process-spawn-typeerror.js
    misterdjules committed Jan 14, 2015
  2. docs: delete unused/duplicate css files

     - `sh.css` already exists in `api_assets`
     - `sh_vim-dark.css` is unused, but used in the repo `node-website`
            now
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
    robertkowalski committed with misterdjules Jan 7, 2015
Commits on Jan 13, 2015
  1. test: backport use executable in spawn() test

    Backport 1070377 from the v0.12 branch.
    
    Currently, the test-child-process-spawn-typeerror.js is
    calling execFile() on a JavaScript source file, which is
    causing failures on Windows. This commit switches to calling
    spawn() on an actual executable.
    
    Fixes #8930.
    
    Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
    cjihrig committed with misterdjules Dec 23, 2014
  2. Merge remote-tracking branch 'upstream/v0.10' into v0.12

    Conflicts:
    	deps/v8/src/debug-debugger.js
    	deps/v8/src/mirror-debugger.js
    	deps/v8/src/platform-freebsd.cc
    	deps/v8/src/platform-linux.cc
    	deps/v8/src/platform-macos.cc
    	deps/v8/src/platform-openbsd.cc
    	deps/v8/src/platform-posix.cc
    	deps/v8/src/platform-solaris.cc
    	deps/v8/tools/gyp/v8.gyp
    misterdjules committed Jan 13, 2015
  3. deps: revert backport b593aa8 from v8 upstream

    This reverts commit 45f1330.
    
    45f1330 was basically breaking
    node-inspector. V8 landed a patch upstream that would probably fix these
    issues (see https://codereview.chromium.org/813873007), but without the
    ability to properly test it in the wild, it's safer to just revert the
    breaking change.
    
    Fixes #8948.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    misterdjules committed Jan 8, 2015
  4. child_process: fix test after latest merge

    child_process.spawn's argument parsing is stricter in v0.12 than in
    v0.10. Changes in tests merged from v0.10 that relied on the less-strict
    argument parsing would fail. This change updates the test so that it
    makes sure that the stricter argument parsing fails as expected.
    
    This change also fixes a small typo introduced during the conflicts
    resolution of said merge.
    misterdjules committed Jan 13, 2015
  5. fs: add access() and accessSync()

    fs.exists() and fs.existsSync() do not follow the typical error first
    callback convention. access() and accessSync() are added as alternatives
    in this commit.
    
    PR-URL: nodejs#8714
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    cjihrig committed with trevnorris Nov 11, 2014
  6. test: use executable in spawn() test

    Currently, the test-child-process-spawn-typeerror.js is
    calling execFile() on a JavaScript source file, which is
    causing failures on Windows. This commit switches to calling
    spawn() on an actual executable.
    
    Reviewed-by: Sam Roberts <sam@strongloop.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
    cjihrig committed with misterdjules Dec 22, 2014
  7. tests: append instead of override environment

    Some tests that rely on some environment variables being passed to child
    processes would fail because they reset the child processes'
    environement instead of appending to it. This would break on test
    environments where some custom environment variables are needed to make
    node work properly.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    misterdjules committed Dec 20, 2014
  8. src: fix indentation in _tls_wrap.js

    Fix indentation issue in code added during the latest merge. This change
    makes jslint pass for _tls_wrap.js.
    misterdjules committed Jan 13, 2015
  9. v8: don't busy loop in cpu profiler thread

    Reduce the overhead of the CPU profiler by replacing sched_yield() with
    nanosleep() in V8's tick event processor thread.  The former only yields
    the CPU when there is another process scheduled on the same CPU.
    
    Before this commit, the thread would effectively busy loop and consume
    100% CPU time.  By forcing a one nanosecond sleep period rounded up to
    the task scheduler's granularity (about 50 us on Linux), CPU usage for
    the processor thread now hovers around 10-20% for a busy application.
    
    PR-URL: nodejs#8789
    Ref: strongloop/strong-agent#3
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    bnoordhuis committed with trevnorris Nov 27, 2014
  10. deps: remove duplicate uv__loop_configure

    The latest merge resulted in uv__loop_configure being defined twice on
    Windows. This changes removes one of these duplicates to fix the build
    on this platform.
    misterdjules committed Jan 13, 2015
Commits on Jan 12, 2015
  1. Merge remote-tracking branch 'upstream/v0.10' into merge-0-10-into-0-12

    Conflicts:
    	AUTHORS
    	ChangeLog
    	configure
    	deps/uv/AUTHORS
    	deps/uv/ChangeLog
    	deps/uv/README.md
    	deps/uv/config-unix.mk
    	deps/uv/include/uv-private/uv-win.h
    	deps/uv/include/uv.h
    	deps/uv/src/unix/internal.h
    	deps/uv/src/unix/kqueue.c
    	deps/uv/src/unix/stream.c
    	deps/uv/src/uv-common.c
    	deps/uv/src/uv-common.h
    	deps/uv/src/version.c
    	deps/uv/src/win/poll.c
    	deps/uv/test/test-osx-select.c
    	deps/v8/src/debug-debugger.js
    	deps/v8/src/isolate.cc
    	deps/v8/src/isolate.h
    	deps/v8/src/mirror-debugger.js
    	doc/api/buffer.markdown
    	doc/api/child_process.markdown
    	doc/api/dns.markdown
    	doc/api/tls.markdown
    	doc/api/url.markdown
    	lib/_stream_writable.js
    	lib/assert.js
    	lib/child_process.js
    	lib/crypto.js
    	lib/dgram.js
    	lib/http.js
    	lib/net.js
    	lib/timers.js
    	lib/tls.js
    	src/node.cc
    	src/node.h
    	src/node.js
    	src/node_crypto.cc
    	src/node_version.h
    	test/common.js
    	test/simple/test-child-process-spawn-typeerror.js
    	tools/certdata.txt
    misterdjules committed Jan 12, 2015
Commits on Jan 8, 2015
  1. test: fix test-process-active-wraps.js

    b636ba8 caused a regression
    on Windows due to the way server handles are cleaned up. This
    commit fixes the test by allowing the handle to be cleaned up.
    
    Fixes: nodejs#8986
    PR-URL: nodejs#8998
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    Reviewed-By: Bert Belder <bertbelder@gmail.com>
    cjihrig committed Jan 8, 2015
Commits on Jan 7, 2015
  1. src,zlib: revert concatenated-stream changes

    Revert "src: fix windows build error" and "zlib: support
    concatenated gzip files". Treating subsequent data as a
    concatenated stream breaks npm install.
    
    This reverts commits 93533e9
    and 6f6a979.
    
    Fixes: nodejs#8962
    PR-URL: nodejs#8985
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    chrisdickinson committed Jan 6, 2015
Commits on Jan 5, 2015
  1. smalloc: fix bad assert for zero length data

    If the data length passed to smalloc.alloc() the array_length will be
    zero, causing an overflow check to fail. This prevents that from
    happening.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    trevnorris committed Jan 5, 2015
Commits on Jan 4, 2015
  1. net: make connect() input validation synchronous

    Socket.prototype.connect() sometimes throws on bad inputs
    after an asynchronous operation. This commit makes the input
    validation synchronous. This commit also removes some hard
    coded IP addresses.
    
    PR-URL: nodejs#8180
    Fixes: nodejs#8140
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    cjihrig committed Jan 3, 2015
Commits on Jan 3, 2015
  1. docs: update to authors file

    PR-URL: nodejs#8964
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    srl295 committed with trevnorris Jan 3, 2015
  2. build: i18n: add icu config options

    Make "--with-intl=none" the default and add "intl-none" option to
    vcbuild.bat.
    
    If icu data is missing print a warning unless either --download=all or
    --download=icu is set. If set then automatically download, verify (MD5)
    and unpack the ICU data if not already available.
    
    There's a "list" of URLs being used, but right now only the first is
    picked up. The logic works something like this:
    
    * If there is no directory deps/icu,
      * If no zip file (currently icu4c-54_1-src.zip),
        * Download zip file (icu-project.org -> sf.net)
      * Verify the MD5 sum of the zipfile
        * If bad, print error and exit
      * Unpack the zipfile into deps/icu
    * If deps/icu now exists, use it, else fail with help text
    
    Add the configuration option "--with-icu-source=..."
    
    Usage:
      * --with-icu-source=/path/to/my/other/icu
      * --with-icu-source=/path/to/icu54.zip
      * --with-icu-source=/path/to/icu54.tgz
      * --with-icu-source=http://example.com/icu54.tar.bz2
    
    Add the configuration option "--with-icu-locals=...".  Allows choosing
    which locales are used in the "small-icu" case.
    
    Example:
        configure --with-intl=small-icu --with-icu-locales=tlh,grc,nl
    
    (Also note that as of this writing, neither Klingon nor Ancient Greek
    are in upstream CLDR data. Serving suggestion only.)
    
    Don't use hard coded ../../out paths on windows. This was suggested by
    @misterdjules as it causes test failures.  With this fix, "out" is no
    longer created on windows and the following can run properly:
    
        python tools/test.py simple
    
    Reduce space by about 1MB with ICU 54 (over without this patch). Also
    trims a few other source files, but only conditional on the exact ICU
    version used. This is to future-proof - a file that is unneeded now may
    be needed in future ICUs.
    
    Also:
      * Update distclean to remove icu related files
      * Refactor some code into tools/configure.d/nodedownload.py
      * Update docs
      * Add test
    
    PR-URL: nodejs#8719
    Fixes: nodejs#7676 (comment)
    [trev.norris@gmail.com small change to test's whitespace and logic]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    srl295 committed with trevnorris Nov 13, 2014
Commits on Dec 30, 2014
  1. url: improve parsing speed

    The url.parse() function now checks whether an escapable character is in
    the URL before trying to escape it.
    
    PR-URL: nodejs#8638
    [trev.norris@gmail.com: Switch to use continue instead of if]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    CGavrila committed with trevnorris Oct 28, 2014
Commits on Dec 24, 2014
  1. Now working on 0.10.36

    tjfontaine committed Dec 24, 2014
Commits on Dec 22, 2014
  1. 2014.12.22, Version 0.10.35 (Stable)

    * tls: re-add 1024-bit SSL certs removed by f9456a2 (Chris Dickinson)
    
    * timers: don't close interval timers when unrefd (Julien Gilli)
    
    * timers: don't mutate unref list while iterating it (Julien Gilli)
    tjfontaine committed Dec 22, 2014