Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jan 19, 2015
  1. @frankcash @geek

    README: fix link text

    frankcash authored geek committed
    Extends a hyperlink to cover the whole line
    PR-URL: #8972
    Reviewed-by: Colin Ihrig <>
Commits on Jan 16, 2015
  1. @tjfontaine

    Merge remote-tracking branch 'upstream/v0.12'

    tjfontaine authored
  2. @tjfontaine @misterdjules

    test: debug-signal-cluster should not be racey

    tjfontaine authored misterdjules committed
    unref one superfluous timer (as the test suite already has a global
    timeout), and improve the state machine to iterate the messages more
    Ultimately make the test complete more quickly.
    Signed-off-by: Julien Gilli <>
  3. @tjfontaine @misterdjules

    cluster: avoid race enabling debugger in worker

    tjfontaine authored misterdjules committed
    Previously if a worker's state machine had already transitioned into the
    'listening' state when it received the message enabling the debugger,
    the worker would never enable its debugger.
    Change the logic to allow the 'listening' as a valid state for enabling
    the debugger.
    Fixes #6440
    Signed-off-by: Julien Gilli <>
Commits on Jan 15, 2015
  1. @piscisaureus @misterdjules

    path: don't lower-cases drive letters

    piscisaureus authored misterdjules committed
    In general path functions don't change the case of a path. Making an
    exception for windows drive letters violates the principle of least
    Changing the drive letter case has caused a lot of issues, including
    joyent/node#7031, joyent/node#7806 and lots of bikeshedding about
    whether uppercase is the right case or lowercase.
    This effectively reverts joyent/node@a05f973
    Reviewed-by: Alexis Campailla <>
    Reviewed-by: Julien Gilli <>
  2. @misterdjules

    build: add small-icu support for binary packages

    misterdjules authored
    Invokes the configure script used to build binary packages
    (OSX pkg, binary tarballs, pkgsrc, MSI) with --download=all
    Also makes PACKAGEMAKER customizable, because PackageMaker is not
    necessarily installed in /Developer on OSX anymore.
    Tested all binary packages on Windows, OSX, Linux and SmartOS.
    Fixes #7676.
    Reviewed-by: Steven R. Loomis <>
    Reviewed-by: Trevor Norris <>
  3. @misterdjules

    test: fix ssl/tls options matrix test

    misterdjules authored
    The tests suite available in test/external/ssl-options was originally
    written for security fixes made in the v0.10 branch. In this branch, the
    client's default ciphers list is compatible with SSLv2.
    After merging this change from v0.10 to v0.12, this tests suite was
    broken because commits 5d2aef1 and
    f4c8020 make SSL/TLS clients use a
    default ciphers list that is not compatible with the SSLv2 protocol.
    This change fixes two issues:
    1) The cipher list that was setup for a given test was not passed
    properly to the client.
    2) When either or both of clients/servers were using SSLv2, tests were
    expected to succeed when at least the server end was using SSLv2
    compatible ciphers. Now, tests are expected to succeed only if
    SSLv2 compatible ciphers are used on both ends.
    Fixes #9020.
    Reviewed-by: Trevor Norris <>
  4. @misterdjules

    test: fix test-crypto-stream.js

    misterdjules authored
    A recent merge of v0.10 to v0.12
    (0c7f6ca) upgraded OpenSSL to version
    1.0.1j. In v0.10, this required test-crypto-stream.js to be fixed with
    commit 707cc25. Basically, instead of
    returning the proper error, Err_get_error() would return 0 and the test
    for the error message needed to be updated in test-crypto-stream.js.
    However, in the v0.12 branch, crypto error messages are handled a bit
    differently since commit 26a1b71
    landed. Instead of returning the default OpenSSL error message, it makes
    the decipher stream return a default message specific to Node.js.
    This commit updates test-crypto-stream.js to test the error object
    against the proper default error message.
    Fixes #9019.
    Reviewed-by: Trevor Norris <>
  5. @sam-github @misterdjules

    cluster: don't assert if worker has no handles

    sam-github authored misterdjules committed
    Do not assume that all workers share all shared handles.
    Signed-off-by: Julien Gilli <>
  6. @sam-github @misterdjules

    cluster: cluster.disconnect() should check status

    sam-github authored misterdjules committed
    Workers that are already disconnected but not yet exited should not be
    disconnected, trying to do so raises exceptions.
    Signed-off-by: Julien Gilli <>
Commits on Jan 14, 2015
  1. @misterdjules

    Merge remote-tracking branch 'upstream/v0.10' into v0.12

    misterdjules authored
  2. @robertkowalski @misterdjules

    docs: delete unused/duplicate css files

    robertkowalski authored misterdjules committed
     - `sh.css` already exists in `api_assets`
     - `sh_vim-dark.css` is unused, but used in the repo `node-website`
    Reviewed-by: Trevor Norris <>
    Signed-off-by: Julien Gilli <>
Commits on Jan 13, 2015
  1. @cjihrig @misterdjules

    test: backport use executable in spawn() test

    cjihrig authored misterdjules committed
    Backport 1070377 from the v0.12 branch.
    Currently, the test-child-process-spawn-typeerror.js is
    calling execFile() on a JavaScript source file, which is
    causing failures on Windows. This commit switches to calling
    spawn() on an actual executable.
    Fixes #8930.
    Signed-off-by: Julien Gilli <>
  2. @misterdjules

    Merge remote-tracking branch 'upstream/v0.10' into v0.12

    misterdjules authored
  3. @misterdjules

    deps: revert backport b593aa8 from v8 upstream

    misterdjules authored
    This reverts commit 45f1330.
    45f1330 was basically breaking
    node-inspector. V8 landed a patch upstream that would probably fix these
    issues (see, but without the
    ability to properly test it in the wild, it's safer to just revert the
    breaking change.
    Fixes #8948.
    Reviewed-By: Colin Ihrig <>
    Reviewed-by: Trevor Norris <>
  4. @misterdjules
  5. @misterdjules

    child_process: fix test after latest merge

    misterdjules authored
    child_process.spawn's argument parsing is stricter in v0.12 than in
    v0.10. Changes in tests merged from v0.10 that relied on the less-strict
    argument parsing would fail. This change updates the test so that it
    makes sure that the stricter argument parsing fails as expected.
    This change also fixes a small typo introduced during the conflicts
    resolution of said merge.
  6. @cjihrig @trevnorris

    fs: add access() and accessSync()

    cjihrig authored trevnorris committed
    fs.exists() and fs.existsSync() do not follow the typical error first
    callback convention. access() and accessSync() are added as alternatives
    in this commit.
    PR-URL: joyent#8714
    Reviewed-by: Trevor Norris <>
  7. @indutny @misterdjules
  8. @cjihrig @misterdjules

    test: use executable in spawn() test

    cjihrig authored misterdjules committed
    Currently, the test-child-process-spawn-typeerror.js is
    calling execFile() on a JavaScript source file, which is
    causing failures on Windows. This commit switches to calling
    spawn() on an actual executable.
    Reviewed-by: Sam Roberts <>
    Reviewed-by: Julien Gilli <>
  9. @misterdjules

    tests: append instead of override environment

    misterdjules authored
    Some tests that rely on some environment variables being passed to child
    processes would fail because they reset the child processes'
    environement instead of appending to it. This would break on test
    environments where some custom environment variables are needed to make
    node work properly.
    Reviewed-By: Colin Ihrig <>
    Reviewed-by: Trevor Norris <>
  10. @misterdjules

    src: fix indentation in _tls_wrap.js

    misterdjules authored
    Fix indentation issue in code added during the latest merge. This change
    makes jslint pass for _tls_wrap.js.
  11. @bnoordhuis @trevnorris

    v8: don't busy loop in cpu profiler thread

    bnoordhuis authored trevnorris committed
    Reduce the overhead of the CPU profiler by replacing sched_yield() with
    nanosleep() in V8's tick event processor thread.  The former only yields
    the CPU when there is another process scheduled on the same CPU.
    Before this commit, the thread would effectively busy loop and consume
    100% CPU time.  By forcing a one nanosecond sleep period rounded up to
    the task scheduler's granularity (about 50 us on Linux), CPU usage for
    the processor thread now hovers around 10-20% for a busy application.
    PR-URL: joyent#8789
    Ref: strongloop/strong-agent#3
    Reviewed-by: Trevor Norris <>
  12. @misterdjules

    deps: remove duplicate uv__loop_configure

    misterdjules authored
    The latest merge resulted in uv__loop_configure being defined twice on
    Windows. This changes removes one of these duplicates to fix the build
    on this platform.
Commits on Jan 12, 2015
  1. @misterdjules

    Merge remote-tracking branch 'upstream/v0.10' into merge-0-10-into-0-12

    misterdjules authored
Commits on Jan 8, 2015
  1. @cjihrig

    test: fix test-process-active-wraps.js

    cjihrig authored
    b636ba8 caused a regression
    on Windows due to the way server handles are cleaned up. This
    commit fixes the test by allowing the handle to be cleaned up.
    Fixes: joyent#8986
    PR-URL: joyent#8998
    Reviewed-By: Julien Gilli <>
    Reviewed-By: Bert Belder <>
Commits on Jan 7, 2015
  1. @chrisdickinson

    src,zlib: revert concatenated-stream changes

    chrisdickinson authored
    Revert "src: fix windows build error" and "zlib: support
    concatenated gzip files". Treating subsequent data as a
    concatenated stream breaks npm install.
    This reverts commits 93533e9
    and 6f6a979.
    Fixes: joyent#8962
    PR-URL: joyent#8985
    Reviewed-By: Julien Gilli <>
Commits on Jan 5, 2015
  1. @trevnorris

    smalloc: fix bad assert for zero length data

    trevnorris authored
    If the data length passed to smalloc.alloc() the array_length will be
    zero, causing an overflow check to fail. This prevents that from
    Signed-off-by: Trevor Norris <>
Commits on Jan 4, 2015
  1. @cjihrig

    net: make connect() input validation synchronous

    cjihrig authored
    Socket.prototype.connect() sometimes throws on bad inputs
    after an asynchronous operation. This commit makes the input
    validation synchronous. This commit also removes some hard
    coded IP addresses.
    PR-URL: joyent#8180
    Fixes: joyent#8140
    Reviewed-By: Trevor Norris <>
    Reviewed-By: Fedor Indutny <>
    Reviewed-By: Timothy J Fontaine <>
Commits on Jan 3, 2015
  1. @srl295 @trevnorris

    docs: update to authors file

    srl295 authored trevnorris committed
    PR-URL: joyent#8964
    Reviewed-by: Trevor Norris <>
  2. @srl295 @trevnorris

    build: i18n: add icu config options

    srl295 authored trevnorris committed
    Make "--with-intl=none" the default and add "intl-none" option to
    If icu data is missing print a warning unless either --download=all or
    --download=icu is set. If set then automatically download, verify (MD5)
    and unpack the ICU data if not already available.
    There's a "list" of URLs being used, but right now only the first is
    picked up. The logic works something like this:
    * If there is no directory deps/icu,
      * If no zip file (currently,
        * Download zip file ( ->
      * Verify the MD5 sum of the zipfile
        * If bad, print error and exit
      * Unpack the zipfile into deps/icu
    * If deps/icu now exists, use it, else fail with help text
    Add the configuration option "--with-icu-source=..."
      * --with-icu-source=/path/to/my/other/icu
      * --with-icu-source=/path/to/
      * --with-icu-source=/path/to/icu54.tgz
      * --with-icu-source=
    Add the configuration option "--with-icu-locals=...".  Allows choosing
    which locales are used in the "small-icu" case.
        configure --with-intl=small-icu --with-icu-locales=tlh,grc,nl
    (Also note that as of this writing, neither Klingon nor Ancient Greek
    are in upstream CLDR data. Serving suggestion only.)
    Don't use hard coded ../../out paths on windows. This was suggested by
    @misterdjules as it causes test failures.  With this fix, "out" is no
    longer created on windows and the following can run properly:
        python tools/ simple
    Reduce space by about 1MB with ICU 54 (over without this patch). Also
    trims a few other source files, but only conditional on the exact ICU
    version used. This is to future-proof - a file that is unneeded now may
    be needed in future ICUs.
      * Update distclean to remove icu related files
      * Refactor some code into tools/configure.d/
      * Update docs
      * Add test
    PR-URL: joyent#8719
    Fixes: joyent#7676 (comment)
    [ small change to test's whitespace and logic]
    Signed-off-by: Trevor Norris <>
Commits on Dec 30, 2014
  1. @CGavrila @trevnorris

    url: improve parsing speed

    CGavrila authored trevnorris committed
    The url.parse() function now checks whether an escapable character is in
    the URL before trying to escape it.
    PR-URL: joyent#8638
    [ Switch to use continue instead of if]
    Signed-off-by: Trevor Norris <>
Commits on Dec 24, 2014
  1. @tjfontaine

    Now working on 0.10.36

    tjfontaine authored
  2. @tjfontaine
Commits on Dec 22, 2014
  1. @tjfontaine

    2014.12.22, Version 0.10.35 (Stable)

    tjfontaine authored
    * tls: re-add 1024-bit SSL certs removed by f9456a2 (Chris Dickinson)
    * timers: don't close interval timers when unrefd (Julien Gilli)
    * timers: don't mutate unref list while iterating it (Julien Gilli)
Something went wrong with that request. Please try again.